-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VID] AvidM integration #2579
Merged
[VID] AvidM integration #2579
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
5374644
ongoing work
mrain f60162c
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain a079d7f
ongoing fix
mrain d14ecdb
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain 971d8c4
lol it compiles
mrain 23152d4
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain 34dba21
metadata for vid_commitment
mrain 1c8ee77
shipping in vid crate
mrain 3b5c135
fixed size ref
mrain fd1464d
fmt & feature tune
mrain c30d4f9
cargo lock
mrain 841f2d0
bug fix & fmt
mrain f4688cd
bug fix and features
mrain a46bbdd
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain f5e3e71
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain a857a1a
fix tests
mrain 83b4b0a
fix sequencer test
mrain 45976cf
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain f7c82f9
Merge branch 'main' into cl/newvid
mrain 02f8048
update for hang problem
mrain 4e39f6e
Merge branch 'cl/newvid' of github.com:EspressoSystems/espresso-seque…
mrain 2ee0796
update ci
mrain 015aa10
addressing comments
mrain a2657f8
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain 33154f1
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain 25c2965
tune Cargo.toml. rename interface for NsAvidMShare.
mrain 87dc2a1
Merge branches 'cl/newvid' and 'main' of github.com:EspressoSystems/e…
mrain 91cfee7
Merge branch 'main' into cl/newvid
mrain e8e07f2
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the test currently hanging or not?
I think we should continue to run this if you moved the calculation out of
spawn_blocking
and it works. or, at most, I think we should maybe#[ignore]
the specific tests that aren't workingthe workflows aren't well-organized so this is disabling some integration tests too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spawn_blocking
is still there. The conclusion was that the real problem is in the test code. There is a ticket for that: #2664