Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VID] AvidM integration #2579

Merged
merged 29 commits into from
Feb 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
5374644
ongoing work
mrain Feb 11, 2025
f60162c
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain Feb 11, 2025
a079d7f
ongoing fix
mrain Feb 11, 2025
d14ecdb
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain Feb 13, 2025
971d8c4
lol it compiles
mrain Feb 18, 2025
23152d4
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain Feb 18, 2025
34dba21
metadata for vid_commitment
mrain Feb 19, 2025
1c8ee77
shipping in vid crate
mrain Feb 19, 2025
3b5c135
fixed size ref
mrain Feb 19, 2025
fd1464d
fmt & feature tune
mrain Feb 19, 2025
c30d4f9
cargo lock
mrain Feb 19, 2025
841f2d0
bug fix & fmt
mrain Feb 19, 2025
f4688cd
bug fix and features
mrain Feb 20, 2025
a46bbdd
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain Feb 20, 2025
f5e3e71
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain Feb 20, 2025
a857a1a
fix tests
mrain Feb 20, 2025
83b4b0a
fix sequencer test
mrain Feb 21, 2025
45976cf
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain Feb 21, 2025
f7c82f9
Merge branch 'main' into cl/newvid
mrain Feb 21, 2025
02f8048
update for hang problem
mrain Feb 21, 2025
4e39f6e
Merge branch 'cl/newvid' of github.com:EspressoSystems/espresso-seque…
mrain Feb 21, 2025
2ee0796
update ci
mrain Feb 21, 2025
015aa10
addressing comments
mrain Feb 24, 2025
a2657f8
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain Feb 24, 2025
33154f1
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain Feb 25, 2025
25c2965
tune Cargo.toml. rename interface for NsAvidMShare.
mrain Feb 25, 2025
87dc2a1
Merge branches 'cl/newvid' and 'main' of github.com:EspressoSystems/e…
mrain Feb 25, 2025
91cfee7
Merge branch 'main' into cl/newvid
mrain Feb 25, 2025
e8e07f2
Merge branch 'main' of github.com:EspressoSystems/espresso-sequencer …
mrain Feb 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cargo-features.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ jobs:
# as each individual feature enabled.
- name: Check compilation for feature combinations
run: |
cargo hack check --feature-powerset --exclude hotshot --exclude hotshot-builder-api --exclude hotshot-task-impls --exclude hotshot-macros --exclude hotshot-events-service --exclude hotshot-utils --exclude hotshot-orchestrator --exclude hotshot-query-service --exclude hotshot-stake-table --exclude hotshot-state-prover --exclude hotshot-task --exclude hotshot-testing --exclude hotshot-types --exclude hotshot-libp2p-networking --exclude hotshot-contract-adapter --exclude hotshot-example-types
cargo hack check --feature-powerset --exclude hotshot --exclude hotshot-builder-api --exclude hotshot-task-impls --exclude hotshot-macros --exclude hotshot-events-service --exclude hotshot-utils --exclude hotshot-orchestrator --exclude hotshot-query-service --exclude hotshot-stake-table --exclude hotshot-state-prover --exclude hotshot-task --exclude hotshot-testing --exclude hotshot-types --exclude hotshot-libp2p-networking --exclude hotshot-contract-adapter --exclude hotshot-example-types --exclude vid

- name: Check compilation for feature combinations (--tests)
run: |
cargo hack check --feature-powerset --tests --exclude hotshot --exclude hotshot-builder-api --exclude hotshot-task-impls --exclude hotshot-macros --exclude hotshot-events-service --exclude hotshot-utils --exclude hotshot-orchestrator --exclude hotshot-query-service --exclude hotshot-stake-table --exclude hotshot-state-prover --exclude hotshot-task --exclude hotshot-testing --exclude hotshot-types --exclude hotshot-libp2p-networking --exclude hotshot-contract-adapter --exclude hotshot-example-types
cargo hack check --feature-powerset --tests --exclude hotshot --exclude hotshot-builder-api --exclude hotshot-task-impls --exclude hotshot-macros --exclude hotshot-events-service --exclude hotshot-utils --exclude hotshot-orchestrator --exclude hotshot-query-service --exclude hotshot-stake-table --exclude hotshot-state-prover --exclude hotshot-task --exclude hotshot-testing --exclude hotshot-types --exclude hotshot-libp2p-networking --exclude hotshot-contract-adapter --exclude hotshot-example-types --exclude vid
2 changes: 1 addition & 1 deletion .github/workflows/hotshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
matrix:
test_suites:
- test-ci-1
# - test-ci-1 temporarily disabled for (https://github.com/EspressoSystems/espresso-sequencer/issues/2664)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the test currently hanging or not?

I think we should continue to run this if you moved the calculation out of spawn_blocking and it works. or, at most, I think we should maybe #[ignore] the specific tests that aren't working

the workflows aren't well-organized so this is disabling some integration tests too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spawn_blocking is still there. The conclusion was that the real problem is in the test code. There is a ticket for that: #2664

- test-ci-2
- test-ci-3
- test-ci-4
Expand Down
Loading
Loading