Skip to content

Commit

Permalink
CI: maybe fix process compose logs
Browse files Browse the repository at this point in the history
Remove -D detach when running process compose. Currently we only get the
process compose internal logs which aren't useful. We would like to have
the logs from the native demo.
  • Loading branch information
sveitser committed Mar 7, 2025
1 parent 327830e commit 6aa494a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
12 changes: 9 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,10 @@ jobs:
version: [02,99]
include:
- version: 02
compose: "-f process-compose.yaml -D"
compose: "-f process-compose.yaml"

- version: 99
compose: "-f process-compose.yaml -f process-compose-mp.yml -D"
compose: "-f process-compose.yaml -f process-compose-mp.yml"
fail-fast: false
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -243,7 +243,7 @@ jobs:
run: nix profile install nixpkgs#process-compose

- name: Run Demo-Native ${{matrix.version}}
run: bash -x scripts/demo-native ${{matrix.compose}} --tui=false
run: bash -x scripts/demo-native ${{matrix.compose}} --tui=false > ${{ env.PC_LOGS }} 2>&1 &

- name: Test Integration
env:
Expand All @@ -255,13 +255,19 @@ jobs:
--workspace-remap $PWD $(if [ "${{ matrix.version }}" == "2" ]; then echo " smoke"; fi)
timeout-minutes: 10

- name: Show end of logs
if: always()
run: |
tail -n 1000 ${{ env.PC_LOGS }}
- name: Upload process compose logs
if: always()
uses: actions/upload-artifact@v4
with:
name: process-compose-logs-integration-v${{ matrix.version }}
path: ${{ env.PC_LOGS }}


demo-native:
needs: build-test-bins
runs-on: ubuntu-latest
Expand Down
1 change: 0 additions & 1 deletion process-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ environment:
- ESPRESSO_STATE_RELAY_SERVER_URL=http://localhost:$ESPRESSO_STATE_RELAY_SERVER_PORT
- QUERY_SERVICE_URI=http://localhost:$ESPRESSO_SEQUENCER1_API_PORT/v0/
- NODE_VALIDATOR_URI=ws://localhost:$ESPRESSO_NODE_VALIDATOR_PORT/v0/
log_location: /tmp/pc.log
processes:
# Cheating a bit here but since we don't usually have to debug go-ethereum
# it's using the docker compose service which is a bit easier.
Expand Down

0 comments on commit 6aa494a

Please sign in to comment.