Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-1186 AI Accelerator updates for 2.1.1 #6445

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

djw-m
Copy link
Contributor

@djw-m djw-m commented Jan 30, 2025

What Changed?

Updates for credentials and replacement of credentials.

Signed-off-by: Dj Walker-Morgan <dj.walker-morgan@enterprisedb.com>
@djw-m djw-m added the deploy Add this label to a PR and it will automatically be deployed to netlify label Jan 30, 2025
@djw-m djw-m self-assigned this Jan 30, 2025
@djw-m djw-m requested a review from a team as a code owner January 30, 2025 09:34
Copy link

@timwaizenegger timwaizenegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

2.1.1 release is scheduled for Monday (Feb 3rd) right now.

Copy link
Contributor

github-actions bot commented Jan 30, 2025

@github-actions github-actions bot temporarily deployed to pull request January 30, 2025 09:43 Inactive
@djw-m djw-m changed the title Updates for 2.1.1 credentials DOCS-1186 AI Accelerator updates for 2.1.1 Jan 30, 2025
djw-m and others added 2 commits January 31, 2025 13:06
Signed-off-by: Dj Walker-Morgan <dj.walker-morgan@enterprisedb.com>
@djw-m djw-m added deploy Add this label to a PR and it will automatically be deployed to netlify and removed deploy Add this label to a PR and it will automatically be deployed to netlify labels Jan 31, 2025
@github-actions github-actions bot temporarily deployed to pull request January 31, 2025 13:12 Inactive
@timwaizenegger
Copy link

FYI; this release includes the first pieces for an upcoming "document prep pipeline"; i.e. SQL primitives to chunk text and similar.

We're dark-launching these for now so they should not be mentioned in the release notes. Interfaces are subject to change and not everything is finished yet.

... as discussed with @noahbaculi

@@ -21,7 +21,7 @@ The starting point for this process is creating a model. When you create a model
```sql
select aidb.create_model(
'my_local_ollama',
'openai_embeddings',
'embeddings',
'{"model":"llama3.3", "url":"http://llama.local:11434/v1/embeddings", "dimensions":8192}'::JSONB,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to add a warning somewhere after this example about the pgvector limitation. Since it doesn't support storing over 2000 vectors. Otherwise, this example can be misleading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to remember how I got to 8192... will bring the local box up and see about shrinking it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code may indicate the maximum is 8192, but there. is a non-obvious technical limitation of 2000.

Copy link

@iakinsey iakinsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one minor nit on language.


## About Completions

Completions is a text completion model that enables use of any OpenAI API compatible text generation model.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an interface for a common API format I would probably drop the first half of this sentence and say something like:

Enables use of any OpenAI API compatible text generation model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants