EBLINUX-26196: Add support for packages to initrd-generator #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simone-weiss
previously approved these changes
Oct 7, 2024
There was a problem hiding this comment.
ok, once merged I will update https://elektrobit.github.io/ebcl_template/tools/initrd.html
|
@simone-weiss @MofX Can you please review again, I had to do some changes to ensure that the kernel and dependencies are not downloaded and extracted. |
simone-weiss
previously approved these changes
Oct 8, 2024
simone-weiss
previously approved these changes
Oct 8, 2024
|
Finally all tests passed: ebcl@d7d9d6e6fba8:/build/ebcl_build_tools$ pytest
============================================================================================ test session starts ============================================================================================
platform linux -- Python 3.10.12, pytest-8.3.3, pluggy-1.5.0
rootdir: /build/ebcl_build_tools
configfile: pyproject.toml
testpaths: tests
plugins: libtmux-0.37.0, cov-5.0.0
collected 73 items
tests/test_apt.py ....... [ 9%]
tests/test_boot.py .. [ 12%]
tests/test_cache.py .... [ 17%]
tests/test_config.py ..... [ 24%]
tests/test_deb.py ... [ 28%]
tests/test_dependency.py .. [ 31%]
tests/test_fake.py .... [ 36%]
tests/test_files.py ................... [ 63%]
tests/test_initrd.py ........ [ 73%]
tests/test_proxy.py ....... [ 83%]
tests/test_root.py ....... [ 93%]
tests/test_version.py ..... [100%]
====================================================================================== 73 passed in 694.53s (0:11:34) ======================================================================================= |
|
@simone-weiss Can you please approve again? I had to push some test fixes. |
simone-weiss
approved these changes
Oct 9, 2024
thir820
added a commit
to Elektrobit/ebcl_template
that referenced
this pull request
Oct 15, 2024
Update docs to reflect new handling of packages parameter. Related to: Elektrobit/ebcl_build_tools#9 --------- Signed-off-by: Thomas Irgang <148551277+thir820@users.noreply.github.com> Co-authored-by: Jörg Vehlow <github@jv-coder.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initrd-generator shall allow downloading and extracting packages, including dependencies.
This is necessary to provide an easy way to add additional tools to the initrd.img, without requiring a full debootstrap environment as a base.
The user is responsible to ensure that the tools work as expected. The tooling only ensures to download the given packages, including dependencies, and extracts them, but doesn't run any install scripts.