Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom debootstrap primary apt repository #20

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

tomirgang
Copy link
Collaborator

@tomirgang tomirgang commented Nov 18, 2024

Changes

  • Add support for custom apt repository providing the main component
  • Use configured apt repositories instead of separate config parameters.

Dependencies:

none

Tests results

Unit tests:

ebcl@6e8761ec1449:/workspace$ pytest
========================================================================================================== test session starts ==========================================================================================================
platform linux -- Python 3.10.12, pytest-8.3.3, pluggy-1.5.0
rootdir: /workspace
configfile: pyproject.toml
testpaths: tests
plugins: libtmux-0.37.0, cov-6.0.0
collected 71 items                                                                                                                                                                                                                      

tests/test_apt.py .......                                                                                                                                                                                                         [  9%]
tests/test_boot.py ..                                                                                                                                                                                 [ 12%]
tests/test_cache.py ....                                                                                                                                                                              [ 18%]
tests/test_config.py ....                                                                                                                                                                             [ 23%]
tests/test_deb.py ...                                                                                                                                                                                 [ 28%]
tests/test_dependency.py ..                                                                                                                                                                           [ 30%]
tests/test_fake.py ....                                                                                                                                                                               [ 36%]
tests/test_files.py ...................                                                                                                                                                               [ 63%]
tests/test_initrd.py ........                                                                                                                                                                         [ 74%]
tests/test_proxy.py .......                                                                                                                                                                           [ 84%]
tests/test_root.py ......                                                                                                                                                                             [ 92%]
tests/test_version.py .....                                                                                                                                                                           [100%]

====================================================================================== 71 passed in 341.36s (0:05:41) =======================================================================================

Robot tests:

ebcl@6e8761ec1449:/workspace/robot_tests$ robot *.robot
==============================================================================
Boot & Initrd & Root                                                          
==============================================================================
Boot & Initrd & Root.Boot                                                     
==============================================================================
Kernel exists                                                         | PASS |
------------------------------------------------------------------------------
Config is OK                                                          | PASS |
------------------------------------------------------------------------------
Script was executed                                                   | PASS |
------------------------------------------------------------------------------
Boot & Initrd & Root.Boot                                             | PASS |
3 tests, 3 passed, 0 failed
==============================================================================
Boot & Initrd & Root.Initrd                                                   
==============================================================================
Root Device is Mounted                                                | PASS |
------------------------------------------------------------------------------
Devices are Created                                                   | PASS |
------------------------------------------------------------------------------
Rootfs should be set up                                               | PASS |
------------------------------------------------------------------------------
File dummy.txt should be OK                                           | PASS |
------------------------------------------------------------------------------
File other.txt should be OK                                           | PASS |
------------------------------------------------------------------------------
Boot & Initrd & Root.Initrd                                           | PASS |
5 tests, 5 passed, 0 failed
==============================================================================
Boot & Initrd & Root.Root                                                     
==============================================================================
Systemd should exist                                                  | PASS |
------------------------------------------------------------------------------
Fakeoot config executed                                               | PASS |
------------------------------------------------------------------------------
Fakechroot config was executed                                        | PASS |
------------------------------------------------------------------------------
Chroot config was executed                                            | PASS |
------------------------------------------------------------------------------
Boot & Initrd & Root.Root                                             | PASS |
4 tests, 4 passed, 0 failed
==============================================================================
Boot & Initrd & Root                                                  | PASS |
12 tests, 12 passed, 0 failed
==============================================================================
Output:  /workspace/robot_tests/output.xml
Log:     /workspace/robot_tests/log.html
Report:  /workspace/robot_tests/report.html

Developer Checklist:

  • Test: Changes are tested
  • N/A Doc: Documentation has been updated
  • Git: Informative git commit message(s)
  • N/A Issue: If a related GitHub issue exists, linking is done

Checklists for documentation

  • N/A Grammar: the content is grammatically correct
    (spelling, grammar, formatting, US English is used)
  • N/A Comprehensibility/Unambiguousness: the content is easy readable, clear to understand
  • N/A Correctness and consistency: the content is technically correct and consistent,
    no contradictions, no double descriptions
  • N/A Terminology: technical terms are clear and they are used correctly and documented in the glossary
  • N/A Level of detail: the content matches the detail level necessary for the reviewed object

Reviewer checklist:

  • Review: Changes are reviewed
  • Review: Tested by the reviewer

Checklists for documentation

  • Grammar: the content is grammatically correct
    (spelling, grammar, formatting, US English is used)
  • Comprehensibility/Unambiguousness: the content is easy readable, clear to understand
  • Correctness and consistency: the content is technically correct and consistent,
    no contradictions, no double descriptions
  • Terminology: technical terms are clear and they are used correctly and documented in the glossary
  • Level of detail: the content matches the detail level necessary for the reviewed object

@thir820 thir820 force-pushed the custom_debootstrap_repo branch 2 times, most recently from 33e1a60 to 4eaa40f Compare November 19, 2024 08:37
@thir820 thir820 marked this pull request as ready for review November 19, 2024 08:46
@thir820 thir820 force-pushed the custom_debootstrap_repo branch from 4eaa40f to eb3e9a6 Compare November 19, 2024 11:22
- Merge main repo and apt config
- Add EBcL main repo
- Remove elbe support
@thir820 thir820 force-pushed the custom_debootstrap_repo branch from eb3e9a6 to c281144 Compare November 19, 2024 11:23
@thir820 thir820 merged commit 699be47 into main Nov 19, 2024
1 check passed
@MofX MofX deleted the custom_debootstrap_repo branch January 9, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants