Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ros parameter for bond timeout #473

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Feb 13, 2025

Proposed changes

Addresses #469

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

Anything worth mentioning to the reviewers.

@glpuga glpuga force-pushed the glpuga/fix_heartbeat_timeout branch from 3fb15a7 to fd8ace3 Compare February 13, 2025 22:53
@glpuga glpuga marked this pull request as ready for review February 13, 2025 22:54
@glpuga glpuga force-pushed the glpuga/fix_heartbeat_timeout branch 2 times, most recently from e61234d to 26b7e7a Compare February 14, 2025 15:20
Signed-off-by: Gerardo Puga <glpuga@gmail.com>
@glpuga glpuga force-pushed the glpuga/fix_heartbeat_timeout branch from 26b7e7a to 29e7b39 Compare February 14, 2025 15:22
@glpuga glpuga requested a review from hidmic February 14, 2025 15:23
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hidmic
Copy link
Collaborator

hidmic commented Feb 15, 2025

I wonder though, did #471 make this patch somewhat irrelevant to #469? Still a nice feature to have.

Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Gerardo Puga <glpuga@gmail.com>
@glpuga
Copy link
Collaborator Author

glpuga commented Feb 17, 2025

I wonder though, did #471 make this patch somewhat irrelevant to #469? Still a nice feature to have.

It did not, maps with a large obstacle-surface-to-map-area ratio still take a long time to build and might trip the heartbeat. In fact, this would do well to be fixed in nav2 too, because nav2 suffers from issues there too.

See #469 (comment)

@glpuga glpuga merged commit 7856463 into main Feb 17, 2025
10 checks passed
@glpuga glpuga deleted the glpuga/fix_heartbeat_timeout branch February 17, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants