Filling in metadata #23
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 20.16% 20.86% +0.70%
==========================================
Files 2 3 +1
Lines 124 139 +15
==========================================
+ Hits 25 29 +4
- Misses 99 110 +11 ☔ View full report in Codecov by Sentry. |
| @@ -1,21 +1,9 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2018-2021: Michael K. Borregaard, Richard Reeve and EcoJulia | |||
| Copyright (c) 2018-2024 Michael Borregaard, Richard Reeve and Kevin Bonham | |||
There was a problem hiding this comment.
I'm certainly not opposed to this, but also don't know if I've made substantial contribution to the code to warrant inclusion here.
There was a problem hiding this comment.
Thanks @kescobo. I'm forcing the metadata to be consistent across different formats (Project.toml, codemeta.json, .zenodo.json, LICENSE) by developing a metadata package ResearchSoftwareMetadata which does a crosswalk between the formats. You're an author in Project.toml (and I'm totally happy with that), so you're an author in every metadata format, which is why you now appear everywhere else.
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
| Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: |
There was a problem hiding this comment.
I prefer keeping the line breaks myself - better if they were sembr, but 🤷
There was a problem hiding this comment.
The license is now taken from SPDX given whatever you put into the license field in Project.toml. Unfortunately there are no line breaks in the text from there... I'm happy either way tbh, but that's the official text.
| "identifier": "https://ror.org/035b05819" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
| } | |
| }, | |
| { | |
| "type": "Person", | |
| "givenName": "Kevin", | |
| "familyName": "Bonham", | |
| "id": "https://orcid.org/0000-0003-3200-7533", | |
| "affiliation": [ | |
| { | |
| "type": "Organization", | |
| "name": "Wellesley College", | |
| "identifier": "https://ror.org/01srpnj69" | |
| } | |
| ] | |
| } |
Only if you want to include me above (which again, I would not insist on)
Also, there's a non-trivial chance that my affiliation is going to change in the next few months, but I can update as necessary if that happens.
There was a problem hiding this comment.
Thanks - I've added that in. But the only place you need to change anything in is the ror in Project.toml, and then rerun the crosswalk, which you can do by running ResearchSoftwareMetadata.crosswalk() and it will update everywhere else.
|
Thanks for the feedback @kescobo - if you're interested in where these changes come from, you may want to look at the ResearchSoftwareMetadata package, which I'm currently working on. I'm also using JuliaFormatter to clean up the code formatting. Comments welcome there too! |
No description provided.