Skip to content

Commit

Permalink
Fixed a InvalidOperationException and crash that could occur when vie…
Browse files Browse the repository at this point in the history
…wing the Cargo Monitor while it contains cargo.

A TwoWay or OneWayToSource binding cannot work on the read-only property 'need' of type 'EddiDataDefinitions.Cargo'
  • Loading branch information
Tkael committed Jun 23, 2024
1 parent 262e0c7 commit b7f25cb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CargoMonitor/ConfigurationWindow.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
</Style>
</DataGridTextColumn.ElementStyle>
</utility:DataGridNumericColumn>
<utility:DataGridNumericColumn Header="{x:Static resx:CargoMonitor.header_need}" Width="80" Binding="{Binding Path=need, NotifyOnTargetUpdated=True, UpdateSourceTrigger=PropertyChanged, Mode=TwoWay, TargetNullValue={x:Static System:String.Empty}}">
<utility:DataGridNumericColumn Header="{x:Static resx:CargoMonitor.header_need}" Width="80" Binding="{Binding Path=need, NotifyOnTargetUpdated=True, UpdateSourceTrigger=PropertyChanged, Mode=OneWay, TargetNullValue={x:Static System:String.Empty}}">
<DataGridTextColumn.HeaderStyle>
<Style TargetType="DataGridColumnHeader">
<Setter Property="HorizontalContentAlignment" Value="Center" />
Expand Down
2 changes: 2 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
Full details of the variables available for each noted event, and VoiceAttack integrations, are available in the individual [event pages](https://github.com/EDCD/EDDI/wiki/Events).

## 4.0.4-b4
* Cargo Monitor
* Fixed a crash that could occur when viewing the Cargo Monitor while it contains cargo.

## 4.0.4-b3
* Core
Expand Down

0 comments on commit b7f25cb

Please sign in to comment.