Fix ParticleHistogram2D #4779
Merged
Fix ParticleHistogram2D #4779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
bug
ax3l
reviewed
Mar 15, 2024
| @@ -138,6 +138,7 @@ void ParticleHistogram2D::ComputeDiags (int step) | |||
| Array<int,2> tlo{0,0}; // lower bounds | |||
| Array<int,2> thi{m_bin_num_abs-1, m_bin_num_ord-1}; // inclusive upper bounds | |||
| amrex::TableData<amrex::Real,2> d_data_2D(tlo, thi); | |||
| m_h_data_2D.clear(); | |||
There was a problem hiding this comment.
@WeiqunZhang do you see why we leaked (host) memory here?
There was a problem hiding this comment.
It's an amrex bug. 😊 AMReX-Codes/amrex#3807
There was a problem hiding this comment.
WarpX PR #4800 should have brought in the fix from AMReX now.
WeiqunZhang
reviewed
Mar 15, 2024
|
For the initialization of |
Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>
WeiqunZhang
added a commit
to AMReX-Codes/amrex
that referenced
this pull request
Mar 21, 2024
|
#4800 should have brought in the fix for AMReX-Codes/amrex#3807 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
m_h_data_2D.clear();the host memory usage continues growing over the simulation until the process gets killed.(Observed in
24.3and24.2)i.close();andseries.close();were my first suspicion. It didn't help, but it is still probably a good idea to explicitly close the iteration and series.