Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus only on path routing. #227

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Conversation

CathalMullan
Copy link
Contributor

No description provided.

@CathalMullan CathalMullan linked an issue Jan 4, 2025 that may be closed by this pull request
Copy link

codspeed-hq bot commented Jan 4, 2025

CodSpeed Performance Report

Merging #227 will improve performances by 37.36%

Comparing 226-focus-on-path-routing-for-now (cf0f6fd) with main (81a595a)

Summary

⚡ 14 improvements
✅ 2 untouched benchmarks
⁉️ 3 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 226-focus-on-path-routing-for-now Change
⁉️ gitlab delete benchmarks/wayfind 135.5 ms N/A N/A
⁉️ gitlab display benchmarks/wayfind 10.3 ms N/A N/A
⁉️ gitlab insert benchmarks/wayfind 62.4 ms N/A N/A
matchit benchmarks/matchit 10.5 µs 8 µs +32.52%
matchit benchmarks/ntex-router 32.4 µs 29.7 µs +9.08%
matchit benchmarks/path-tree 13.3 µs 10.6 µs +25.42%
matchit benchmarks/route-recognizer 38.3 µs 35.9 µs +6.81%
matchit benchmarks/routefinder 50.3 µs 48 µs +4.68%
matchit benchmarks/wayfind 15.3 µs 11.2 µs +36.84%
matchit benchmarks/xitca-router 11.5 µs 8.4 µs +37.36%
path-tree benchmarks/matchit 77.6 µs 62.3 µs +24.57%
path-tree benchmarks/ntex-router 279.8 µs 265.3 µs +5.49%
path-tree benchmarks/path-tree 81.8 µs 66.1 µs +23.77%
path-tree benchmarks/route-recognizer 541.6 µs 521.3 µs +3.9%
path-tree benchmarks/routefinder 489 µs 474.3 µs +3.1%
path-tree benchmarks/wayfind 80 µs 61.1 µs +30.91%
path-tree benchmarks/xitca-router 84.7 µs 69 µs +22.67%

@CathalMullan CathalMullan force-pushed the 226-focus-on-path-routing-for-now branch 4 times, most recently from 2e61c56 to f1cc718 Compare January 4, 2025 20:06
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 93.36493% with 42 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/delete.rs 48.71% 17 Missing and 3 partials ⚠️
src/errors/delete.rs 88.88% 6 Missing ⚠️
src/router.rs 96.21% 3 Missing and 2 partials ⚠️
src/errors/search.rs 0.00% 3 Missing ⚠️
src/vec.rs 94.33% 3 Missing ⚠️
src/display.rs 66.66% 0 Missing and 2 partials ⚠️
src/errors/insert.rs 91.66% 2 Missing ⚠️
src/find.rs 96.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/constraints.rs 5.88% <ø> (ø)
src/errors/constraint.rs 100.00% <100.00%> (ø)
src/errors/encoding.rs 100.00% <ø> (+21.62%) ⬆️
src/errors/template.rs 98.90% <100.00%> (ø)
src/insert.rs 99.03% <100.00%> (ø)
src/lib.rs 68.29% <ø> (+0.49%) ⬆️
src/node.rs 100.00% <100.00%> (ø)
src/optimize.rs 94.18% <100.00%> (ø)
src/parser.rs 98.25% <100.00%> (ø)
src/search.rs 87.60% <100.00%> (ø)
... and 9 more

@CathalMullan CathalMullan force-pushed the 226-focus-on-path-routing-for-now branch from f1cc718 to cf0f6fd Compare January 4, 2025 21:46
@CathalMullan CathalMullan marked this pull request as ready for review January 4, 2025 21:52
@CathalMullan CathalMullan merged commit db85702 into main Jan 4, 2025
8 checks passed
@CathalMullan CathalMullan deleted the 226-focus-on-path-routing-for-now branch January 4, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus on path routing for now
1 participant