Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document finished features #126

Merged
merged 9 commits into from
Aug 27, 2024
Merged

Document finished features #126

merged 9 commits into from
Aug 27, 2024

Conversation

CathalMullan
Copy link
Contributor

@CathalMullan CathalMullan commented Aug 26, 2024

Both internal and public API needs documentation.

cargo watch --notify --shell "cargo doc --document-private-items"

EDIT:
Doctest support is missing from nextest/llvm-cov, which is annoying for coverage metrics.

EDIT 2:
Suprised there isn't a GHA to upload docs to pages, and comment a link on the PR.

Guess this PR is going to devolve into GHA shenanigans.

EDIT 3:
Pages doesn't support sub-paths.
Need to wait until the 'preview' feature releases: https://github.com/actions/deploy-pages

We can add a docs preview to the main branch, which will still be useful for pre-release checks.

EDIT 4:
Noticed some inconsistencies around our error messages.

EDIT 5:
Leaving the main, crate level documentation to a later date.

@CathalMullan CathalMullan linked an issue Aug 26, 2024 that may be closed by this pull request
Copy link

codspeed-hq bot commented Aug 26, 2024

CodSpeed Performance Report

Merging #126 will not alter performance

Comparing 125-begin-documenting-crate (c08ccf3) with main (3a35573)

Summary

✅ 16 untouched benchmarks

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
src/path.rs 60.00% 2 Missing ⚠️
Files Coverage Δ
src/constraints.rs 0.00% <ø> (ø)
src/decode.rs 78.12% <100.00%> (-18.75%) ⬇️
src/errors/constraint.rs 100.00% <ø> (ø)
src/errors/decode.rs 0.00% <ø> (-100.00%) ⬇️
src/errors/delete.rs 73.33% <ø> (ø)
src/errors/insert.rs 76.47% <ø> (ø)
src/errors/route.rs 100.00% <100.00%> (ø)
src/node/delete.rs 77.77% <ø> (ø)
src/node/insert.rs 91.63% <100.00%> (+0.06%) ⬆️
src/node/search.rs 98.02% <100.00%> (+0.48%) ⬆️
... and 3 more

@CathalMullan CathalMullan force-pushed the 125-begin-documenting-crate branch 14 times, most recently from 20b066e to ec3e516 Compare August 27, 2024 00:37
@DuskSystems DuskSystems deleted a comment from github-actions bot Aug 27, 2024
@DuskSystems DuskSystems deleted a comment from github-actions bot Aug 27, 2024
@DuskSystems DuskSystems deleted a comment from github-actions bot Aug 27, 2024
@DuskSystems DuskSystems deleted a comment from github-actions bot Aug 27, 2024
@CathalMullan CathalMullan force-pushed the main branch 2 times, most recently from 99745b6 to 0620562 Compare August 27, 2024 01:20
@CathalMullan CathalMullan force-pushed the 125-begin-documenting-crate branch 4 times, most recently from 99e6744 to c0598fc Compare August 27, 2024 01:37
@CathalMullan CathalMullan force-pushed the main branch 2 times, most recently from a613666 to 3a35573 Compare August 27, 2024 01:43
@CathalMullan CathalMullan force-pushed the 125-begin-documenting-crate branch from c0598fc to bde28b5 Compare August 27, 2024 01:44
@CathalMullan CathalMullan force-pushed the 125-begin-documenting-crate branch 3 times, most recently from 72d6213 to 6b0d841 Compare August 27, 2024 15:20
@CathalMullan CathalMullan force-pushed the 125-begin-documenting-crate branch from 6b0d841 to d4e0a34 Compare August 27, 2024 15:30
@CathalMullan CathalMullan force-pushed the 125-begin-documenting-crate branch from ea3b6d3 to c08ccf3 Compare August 27, 2024 20:39
@CathalMullan CathalMullan marked this pull request as ready for review August 27, 2024 20:53
@CathalMullan CathalMullan merged commit 0b2d6b4 into main Aug 27, 2024
5 of 6 checks passed
@CathalMullan CathalMullan deleted the 125-begin-documenting-crate branch August 27, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Begin documenting crate
1 participant