-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document finished features #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
CodSpeed Performance ReportMerging #126 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
|
20b066e
to
ec3e516
Compare
99745b6
to
0620562
Compare
99e6744
to
c0598fc
Compare
a613666
to
3a35573
Compare
c0598fc
to
bde28b5
Compare
72d6213
to
6b0d841
Compare
6b0d841
to
d4e0a34
Compare
ea3b6d3
to
c08ccf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both internal and public API needs documentation.
cargo watch --notify --shell "cargo doc --document-private-items"
EDIT:
Doctest support is missing from nextest/llvm-cov, which is annoying for coverage metrics.
EDIT 2:
Suprised there isn't a GHA to upload docs to pages, and comment a link on the PR.
Guess this PR is going to devolve into GHA shenanigans.
EDIT 3:
Pages doesn't support sub-paths.
Need to wait until the 'preview' feature releases: https://github.com/actions/deploy-pages
We can add a docs preview to the main branch, which will still be useful for pre-release checks.
EDIT 4:
Noticed some inconsistencies around our error messages.
EDIT 5:
Leaving the main, crate level documentation to a later date.