FIX units used scale and scale is an integer #32496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 31, 2024
|
@hregis this is not fixing it for me. The fix needs to be applied to: public function update($id, $user, $notrigger = 0, $action = 'update', $updatetype = false) your fix is applied to the public function fetch($id = 0, $ref = '', $ref_ext = '', $barcode = '', $ignore_expression = 0, $ignore_price_load = 0, $ignore_lang_load = 0) Can you check |
|
@erikvanberkum @eldy This first fix allows not to lose the value selected in the "selectMeasuringUnits()" function when the value is empty ("scale" field of the measurement units dictionary) |
erikvanberkum
added a commit
to erikvanberkum/dolibarr
that referenced
this pull request
Jan 5, 2025
solves issue Dolibarr#32495: current Empty testing for 0 results in TRUE and makes it an empty string. Testing for is_null solves the issue. this issue is connected with pull FIX Dolibarr#32496
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.