Make more use of AsyncStatus.wrap #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noemifrisina
approved these changes
Jul 22, 2024
| return AsyncStatus( | ||
| asyncio.wait_for(self._set_armed(demand), timeout=self.TIMEOUT) | ||
| ) | ||
| @AsyncStatus.wrap |
There was a problem hiding this comment.
lgtm, thanks.
I think we could move the code in _set_armed in this set here instead of keeping in split into two functions but I don't feel that strongly about it
There was a problem hiding this comment.
Do you mean make it an inner function of set? We need the function so that we can wait on it with a timeout
There was a problem hiding this comment.
Yes, but I don't mind either way
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
=======================================
Coverage 94.16% 94.16%
=======================================
Files 108 108
Lines 4302 4305 +3
=======================================
+ Hits 4051 4054 +3
Misses 251 251 ☔ View full report in Codecov by Sentry. |
stan-dot
pushed a commit
that referenced
this pull request
Jul 24, 2024
* Make more use of AsyncStatus.wrap * Use RE in smargon so it has an event loop * Fix signature of stop * Fix some typing issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}