Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS pip-packages. Add GCC-macOS configuration to CI. #513

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

Vdaleke
Copy link
Collaborator

@Vdaleke Vdaleke commented Jan 12, 2025

Add macOS wheels to cibuildwheel workflow:

  1. Create a separate job for macOS wheel matrix generation due to wheels autoskipping on x86_64 ubuntu runner.
  2. Create matrix merge job to merge all matrices into a single.
  3. Add macOS support to the wheel build job.

Add macOS-GCC CI configuration:

  1. Add missing steps in install-dependencies action.
  2. Add configruation to core-tests and bindings-tests workflows.
  3. Add --formula flag to brew install cmake to disable warning.

Refactor CI:

  1. Set libraries download in alphabetical order.
  2. Bump actions/checkout to v4.
  3. Change run_tests matrix to more readable. resolves Simplify configuration logic in CI #512
  4. Add env field to avoid code duplications inside job.

Also set C++ as default CMake project language, remove C-compilers exports.
Fix boost libraries building to build only used libraries.

@Vdaleke Vdaleke force-pushed the macOS-pip-package branch 4 times, most recently from 5adf90c to 74905d1 Compare January 12, 2025 21:46
@Vdaleke Vdaleke marked this pull request as ready for review January 12, 2025 23:10
.github/workflows/bindings-tests.yml Outdated Show resolved Hide resolved
.github/workflows/wheel.yml Show resolved Hide resolved
.github/workflows/wheel.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@Vdaleke Vdaleke force-pushed the macOS-pip-package branch 2 times, most recently from a6c4067 to f597e1c Compare January 25, 2025 20:03
@Vdaleke Vdaleke requested a review from p-senichenkov January 25, 2025 20:05
.github/composite-actions/install-dependencies/action.yml Outdated Show resolved Hide resolved
.github/workflows/bindings-tests.yml Outdated Show resolved Hide resolved
.github/workflows/wheel.yml Outdated Show resolved Hide resolved
.github/workflows/wheel.yml Show resolved Hide resolved
.github/workflows/wheel.yml Outdated Show resolved Hide resolved
.github/workflows/wheel.yml Outdated Show resolved Hide resolved
@Vdaleke Vdaleke force-pushed the macOS-pip-package branch 5 times, most recently from f138f81 to 57f64a6 Compare January 27, 2025 19:38
@Vdaleke Vdaleke requested a review from p-senichenkov January 27, 2025 19:39
@Vdaleke Vdaleke force-pushed the macOS-pip-package branch 3 times, most recently from 1ecc0a8 to 377550d Compare January 28, 2025 09:57
.github/workflows/core-tests.yml Outdated Show resolved Hide resolved
.github/workflows/core-tests.yml Outdated Show resolved Hide resolved
.github/workflows/core-tests.yml Outdated Show resolved Hide resolved
.github/workflows/core-tests.yml Outdated Show resolved Hide resolved
.github/workflows/core-tests.yml Outdated Show resolved Hide resolved
.github/workflows/wheel.yml Outdated Show resolved Hide resolved
@Vdaleke Vdaleke force-pushed the macOS-pip-package branch 2 times, most recently from 8495cab to 5a726d3 Compare January 29, 2025 11:23
@Vdaleke Vdaleke requested a review from p-senichenkov January 29, 2025 11:25
@Vdaleke
Copy link
Collaborator Author

Vdaleke commented Jan 29, 2025

@p-senichenkov When you are ready to approve then we will cherry-pick the fc2101e to your branch. You can do it by yourself or I can

@p-senichenkov
Copy link
Collaborator

@p-senichenkov When you are ready to approve then we will cherry-pick the fc2101e to your branch. You can do it by yourself or I can

Please, do it yourself

@Vdaleke
Copy link
Collaborator Author

Vdaleke commented Jan 29, 2025

Please, do it yourself

Done

@p-senichenkov
Copy link
Collaborator

I've brought export CC=clang back to binding-tests in #513 due to some CMake weirdness. Would you kindly check if this change is necessary here (i. e. maybe some other change here fixes this problem)?

@Vdaleke Vdaleke force-pushed the macOS-pip-package branch 2 times, most recently from 495122b to 4e07403 Compare January 31, 2025 13:12
Add missing steps in install-dependencies action.
Add configuration to core-tests and bindings-tests workflows.
Add --formula flag to `brew install cmake` to disable warning.

Fix missed includes in bind_primitive.h

Set C++ as CMake project language, remove C-compilers exports.
Create a separate job for macOS wheel matrix generation due to
wheels autoskipping on x86_64 ubuntu runner.
Create matrix merge job to merge all matrices into a single.
Add macOS support to the wheel build job.
@chernishev chernishev merged commit 8ae77f4 into Desbordante:main Feb 1, 2025
1 of 19 checks passed
@Vdaleke Vdaleke deleted the macOS-pip-package branch February 2, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify configuration logic in CI
3 participants