Skip to content

Commit

Permalink
Don't remove or reset artifacts anymore (#2050)
Browse files Browse the repository at this point in the history
Fixes #1972.
This problem doesn't seem to be happening anymore, possibly since moving
to Windows 11.
  • Loading branch information
visr authored Feb 11, 2025
1 parent d70c1ad commit f28469d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion .teamcity/Templates/Build.kt
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ open class Build(platformOs: String) : Template() {
workingDir = "ribasim"
scriptContent = header +
"""
pixi run remove-artifacts
pixi run build
""".trimIndent()
}
Expand Down
5 changes: 0 additions & 5 deletions pixi.toml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ build = { "cmd" = "julia --project build.jl", cwd = "build", depends-on = [
"generate-testmodels",
"initialize-julia",
], env = { SSL_CERT_DIR = "", JULIA_SSL_CA_ROOTS_PATH = "" } }
remove-artifacts = "julia --eval 'rm(joinpath(Base.DEPOT_PATH[1], \"artifacts\"), force=true, recursive=true)'"
# Tests
test-ribasim-cli = "pytest --numprocesses=4 --basetemp=build/tests/temp --junitxml=report.xml build/tests"
test-ribasim-core = { cmd = "julia --project=core --eval 'using Pkg; Pkg.test()'", depends-on = [
Expand Down Expand Up @@ -155,11 +154,7 @@ github-release = "python utils/github-release.py"

[target.win.tasks]
add-ribasim-icon = { cmd = "rcedit build/ribasim/ribasim.exe --set-icon docs/assets/ribasim.ico" }
# Workaround rare issue on Windows where the permissions of the artifacts directory are incorrect
# Upstream issue: https://github.com/JuliaLang/julia/issues/52272
reset-artifact-permissions = "icacls $homedrive/$homepath/.julia/artifacts /q /c /t /reset"
install-ci = { depends-on = [
# "reset-artifact-permissions", # see #1972
"install-julia",
"update-registry-julia",
] }
Expand Down

0 comments on commit f28469d

Please sign in to comment.