Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL query error reporting #3840

Merged
merged 3 commits into from
Jan 22, 2025
Merged

GraphQL query error reporting #3840

merged 3 commits into from
Jan 22, 2025

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jan 17, 2025

Motivation

Implements RFC: https://docs.google.com/document/d/1JjctLYE4a4EbtmnFixQt-TilltcSV69IAeiSGjcUL34

Capture GraphQL query errors as span events:
Screenshot 2025-01-17 at 3 59 23 PM

Changes

Added a new test scenario graphql for any tests that simply need a GraphQL request, without any special configuration.
Also added the test file tests/test_graphql.py to assert the span event behavior.

The Ruby variant currently passes tests with the changes in DataDog/dd-trace-rb#4177.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@marcotc marcotc force-pushed the marcotc/graphql-error-events branch from 0012eec to 68fb98e Compare January 17, 2025 23:12
@marcotc marcotc force-pushed the marcotc/graphql-error-events branch from 68fb98e to b84854a Compare January 17, 2025 23:53
@marcotc marcotc marked this pull request as ready for review January 18, 2025 00:46
@marcotc marcotc requested review from a team as code owners January 18, 2025 00:46
@marcotc marcotc requested review from taegyunkim, quinna-h, jandro996, Mariovido, dougqh and dmehala and removed request for a team January 18, 2025 00:46
utils/_context/_scenarios/__init__.py Outdated Show resolved Hide resolved
@marcotc marcotc requested a review from cbeauchesne January 21, 2025 19:28
@marcotc marcotc merged commit 5e31a4e into main Jan 22, 2025
431 of 433 checks passed
@marcotc marcotc deleted the marcotc/graphql-error-events branch January 22, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants