Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implements RFC: https://docs.google.com/document/d/1JjctLYE4a4EbtmnFixQt-TilltcSV69IAeiSGjcUL34
Capture GraphQL query errors as span events:
![Screenshot 2025-01-17 at 3 59 23 PM](https://private-user-images.githubusercontent.com/583503/404477056-fc53fd9c-97d2-4604-8593-869f828faa48.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MTIwNDMsIm5iZiI6MTczOTYxMTc0MywicGF0aCI6Ii81ODM1MDMvNDA0NDc3MDU2LWZjNTNmZDljLTk3ZDItNDYwNC04NTkzLTg2OWY4MjhmYWE0OC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwOTI5MDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iNzAwMzMxNDg4ZTcxNzdiZTEzOTY2MDM1NWRmMzI3ZWRiNjU2NDA5OTYwYzI3NDc2OWU0ZmI4MTM3MTA4NTAxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ttTUPCUv7KM8D9DQ4GvO2PfptO8RwjiZP83LrrWgjT0)
Changes
Added a new test scenario
graphql
for any tests that simply need a GraphQL request, without any special configuration.Also added the test file
tests/test_graphql.py
to assert the span event behavior.The Ruby variant currently passes tests with the changes in DataDog/dd-trace-rb#4177.
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present