apply code review suggestion

DataDog · Nov 25, 2024 · 417f247 · 417f247
1 parent 282dae8
commit 417f247
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/charts/datadog/templates/NOTES.txt b/charts/datadog/templates/NOTES.txt
@@ -534,16 +534,16 @@ More information about this change: https://github.com/DataDog/helm-charts/pull/
 {{- end }}
 
 
-{{- if and (ne .Values.targetSystem "linux") (eq (include "should-add-host-path-for-os-release-paths" .) "false") .Values.datadog.sbom.host.enabled }}
+{{- if and (eq .Values.targetSystem "linux") (eq (include "should-add-host-path-for-os-release-paths" .) "false") .Values.datadog.sbom.host.enabled }}
 #################################################################
 ####               ERROR: Configuration notice             ####
 #################################################################
 The SBOM host filesystem collection feature requires access to the os-release information from the host.
-`datadog.sbom.host.enabled: true` can't be use with `datadog.disableDefaultOsReleasePaths: true`.
+`datadog.sbom.host.enabled: true` can't be used with `datadog.disableDefaultOsReleasePaths: true`.
 {{- fail "The SBOM host filesystem collection feature requires access to the os-release information from the host." }}
 {{- end }}
 
-{{- if and (ne .Values.targetSystem "linux") (eq (include "should-add-host-path-for-os-release-paths" .) "false") (eq (include "should-enable-system-probe" .) "true") }}
+{{- if and (eq .Values.targetSystem "linux") (eq (include "should-add-host-path-for-os-release-paths" .) "false") (eq (include "should-enable-system-probe" .) "true") }}
 #################################################################
 ####               ERROR: Configuration notice             ####
 #################################################################

diff --git a/charts/datadog/values.yaml b/charts/datadog/values.yaml
@@ -2315,7 +2315,12 @@ providers:
     enabled: false
 
   talos:
-    # providers.talos.enabled -- Activate all specificities related to Talos.dev configuration. Required as currently we cannot auto-detect Talos.dev.
+    # providers.talos.enabled -- Activate all required specificities related to Talos.dev configuration,
+    # as currently the chart cannot auto-detect Talos.dev cluster.
+    # Note: The Agent deployment requires additional privileges that are not permitted by the default pod security policy.
+    # The annotation `pod-security.kubernetes.io/enforce=privileged` must be applied to the Datadog installation
+    # Kubernetes namespace. For more information on pod security policies in Talos.dev clusters, see:
+    # https://www.talos.dev/v1.8/kubernetes-guides/configuration/pod-security/
     enabled: false
 
 remoteConfiguration: