-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split parametric tests away #4407
Conversation
Thank you for updating Change log entry section 👏 Visited at: 2025-02-19 10:01:33 UTC |
70055de
to
19b92b0
Compare
Parametric tests are independent from System Tests in many ways, notably they have an entirely different run profile, both in runners used and time spent. Instead of blocking system tests workflow final result visibility we split parametric tests away to their own workflow. This also allows for better trackability of CI costs.
19b92b0
to
f5d132d
Compare
Datadog ReportBranch report: ✅ 0 Failed, 20399 Passed, 1374 Skipped, 3m 16s Total Time |
BenchmarksBenchmark execution time: 2025-02-19 10:44:56 Comparing candidate commit f5d132d in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
scenario:line instrumentation - untargeted
scenario:method instrumentation
scenario:profiler - intern_all 1000 repeated strings
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4407 +/- ##
==========================================
+ Coverage 97.69% 97.71% +0.01%
==========================================
Files 1366 1366
Lines 83372 83373 +1
Branches 4230 4230
==========================================
+ Hits 81451 81464 +13
+ Misses 1921 1909 -12 ☔ View full report in Codecov by Sentry. |
What does this PR do?
Split parametric tests away
Motivation:
Parametric tests are independent from System Tests in many ways, notably they have an entirely different run profile, both in runners used and time spent.
Instead of blocking system tests workflow final result visibility we split parametric tests away to their own workflow.
This also allows for better trackability of CI costs.
Change log entry
None.
Additional Notes:
Post-merge,
Parametric Tests
should be made required in GitHub settings.How to test the change?
CI should still pass.