Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split parametric tests away #4407

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented Feb 19, 2025

What does this PR do?

Split parametric tests away

Motivation:

Parametric tests are independent from System Tests in many ways, notably they have an entirely different run profile, both in runners used and time spent.

Instead of blocking system tests workflow final result visibility we split parametric tests away to their own workflow.

This also allows for better trackability of CI costs.

Change log entry

None.

Additional Notes:

Post-merge, Parametric Tests should be made required in GitHub settings.

How to test the change?

CI should still pass.

Copy link

github-actions bot commented Feb 19, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-02-19 10:01:33 UTC

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Feb 19, 2025
@lloeki lloeki force-pushed the lloeki/split-parametric-tests-away branch from 70055de to 19b92b0 Compare February 19, 2025 10:03
Parametric tests are independent from System Tests in many ways, notably
they have an entirely different run profile, both in runners used and
time spent.

Instead of blocking system tests workflow final result visibility we
split parametric tests away to their own workflow.

This also allows for better trackability of CI costs.
@lloeki lloeki force-pushed the lloeki/split-parametric-tests-away branch from 19b92b0 to f5d132d Compare February 19, 2025 10:19
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 19, 2025

Datadog Report

Branch report: lloeki/split-parametric-tests-away
Commit report: f5d132d
Test service: dd-trace-rb

✅ 0 Failed, 20399 Passed, 1374 Skipped, 3m 16s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 19, 2025

Benchmarks

Benchmark execution time: 2025-02-19 10:44:56

Comparing candidate commit f5d132d in PR branch lloeki/split-parametric-tests-away with baseline commit 18de083 in branch master.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟥 throughput [-12776.014op/s; -12041.417op/s] or [-7.686%; -7.244%]

scenario:line instrumentation - untargeted

  • 🟥 throughput [-5542.359op/s; -5228.256op/s] or [-5.796%; -5.468%]

scenario:method instrumentation

  • 🟥 throughput [-14393.395op/s; -13668.690op/s] or [-8.065%; -7.658%]

scenario:profiler - intern_all 1000 repeated strings

  • 🟥 throughput [-3627.567op/s; -3557.563op/s] or [-14.590%; -14.308%]

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (18de083) to head (f5d132d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4407      +/-   ##
==========================================
+ Coverage   97.69%   97.71%   +0.01%     
==========================================
  Files        1366     1366              
  Lines       83372    83373       +1     
  Branches     4230     4230              
==========================================
+ Hits        81451    81464      +13     
+ Misses       1921     1909      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lloeki lloeki marked this pull request as ready for review February 19, 2025 10:38
@lloeki lloeki requested a review from a team as a code owner February 19, 2025 10:38
@lloeki lloeki merged commit aad61dd into master Feb 19, 2025
487 checks passed
@lloeki lloeki deleted the lloeki/split-parametric-tests-away branch February 19, 2025 11:05
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants