-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 3.4.0-preview2 support for github workflow tests #4039
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4039 +/- ##
==========================================
- Coverage 97.73% 97.72% -0.02%
==========================================
Files 1338 1338
Lines 80249 80252 +3
Branches 4016 4017 +1
==========================================
- Hits 78434 78424 -10
- Misses 1815 1828 +13 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-11-06 16:03:51 Comparing candidate commit eb944e7 in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 27 metrics, 2 unstable metrics. scenario:method instrumentation
scenario:profiler - gvl benchmark samples
|
a08df2b
to
b54aa48
Compare
615132e
to
dc959a3
Compare
81d7e69
to
3417385
Compare
8de41bb
to
b30616e
Compare
ff7da23
to
389b442
Compare
7386ae8
to
39c5001
Compare
8cbc54c
to
85f97f2
Compare
85f97f2
to
900bbbe
Compare
900bbbe
to
5686643
Compare
5686643
to
eb944e7
Compare
What does this PR do?
This PR adds Ruby 3.4.0-preview2 support for github workflow tests, specifically macos and yjit, by adding a "3.4" version to the
test-yjit.yaml
andtest-macos.yml
files under.github
. It also updates the Dockerfile-3.4.0 base image toruby:3.4.0-preview2
and adjusts a few of the spec tests, given new Ruby output changes (see here).Motivation:
Though the official Ruby 3.4 is not yet released, we can temporarily add Ruby 3.4.0-preview2. This allows us to start testing with Ruby 3.4 in our CI and spot -> address issues early. After Ruby 3.4 is officially released post-Dec 25, 2024, we can replace the preview with it.
Change log entry
No change log entry for now. Thinking to have a "Ruby 3.4.0-preview2 support added" update after it is fully supported.
Additional Notes:
More Ruby 3.4.0-preview2 support is needed. This PR is one step toward full support and only addresses github workflow tests. It acts alongside #4038 .
How to test the change?
This change can be tested in CI.