Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.4.0-preview2 support for github workflow tests #4039

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Oct 28, 2024

What does this PR do?
This PR adds Ruby 3.4.0-preview2 support for github workflow tests, specifically macos and yjit, by adding a "3.4" version to the test-yjit.yaml and test-macos.yml files under .github. It also updates the Dockerfile-3.4.0 base image to ruby:3.4.0-preview2 and adjusts a few of the spec tests, given new Ruby output changes (see here).

Motivation:
Though the official Ruby 3.4 is not yet released, we can temporarily add Ruby 3.4.0-preview2. This allows us to start testing with Ruby 3.4 in our CI and spot -> address issues early. After Ruby 3.4 is officially released post-Dec 25, 2024, we can replace the preview with it.

Change log entry
No change log entry for now. Thinking to have a "Ruby 3.4.0-preview2 support added" update after it is fully supported.

Additional Notes:
More Ruby 3.4.0-preview2 support is needed. This PR is one step toward full support and only addresses github workflow tests. It acts alongside #4038 .

How to test the change?
This change can be tested in CI.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (25d6fb8) to head (eb944e7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4039      +/-   ##
==========================================
- Coverage   97.73%   97.72%   -0.02%     
==========================================
  Files        1338     1338              
  Lines       80249    80252       +3     
  Branches     4016     4017       +1     
==========================================
- Hits        78434    78424      -10     
- Misses       1815     1828      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Oct 28, 2024

Benchmarks

Benchmark execution time: 2024-11-06 16:03:51

Comparing candidate commit eb944e7 in PR branch sarahchen6/add-ruby-3.4-github with baseline commit 2fae103 in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 27 metrics, 2 unstable metrics.

scenario:method instrumentation

  • 🟥 throughput [-10656.663op/s; -10062.636op/s] or [-5.825%; -5.500%]

scenario:profiler - gvl benchmark samples

  • 🟩 throughput [+618.533op/s; +627.675op/s] or [+5.524%; +5.605%]

@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-ruby-3.4-github branch 2 times, most recently from a08df2b to b54aa48 Compare October 28, 2024 21:07
@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-ruby-3.4-github branch 5 times, most recently from 615132e to dc959a3 Compare October 29, 2024 21:49
@sarahchen6 sarahchen6 marked this pull request as ready for review October 29, 2024 23:27
@sarahchen6 sarahchen6 requested review from a team as code owners October 29, 2024 23:27
@sarahchen6 sarahchen6 mentioned this pull request Oct 30, 2024
@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-ruby-3.4-github branch from 81d7e69 to 3417385 Compare October 30, 2024 18:20
@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-ruby-3.4-github branch from 8de41bb to b30616e Compare October 30, 2024 19:12
@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-ruby-3.4-github branch 5 times, most recently from ff7da23 to 389b442 Compare October 31, 2024 17:26
@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-ruby-3.4-github branch 8 times, most recently from 7386ae8 to 39c5001 Compare October 31, 2024 20:44
@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-ruby-3.4-github branch from 8cbc54c to 85f97f2 Compare November 6, 2024 14:58
@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-ruby-3.4-github branch from 85f97f2 to 900bbbe Compare November 6, 2024 15:05
@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-ruby-3.4-github branch from 900bbbe to 5686643 Compare November 6, 2024 15:22
@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-ruby-3.4-github branch from 5686643 to eb944e7 Compare November 6, 2024 15:24
@TonyCTHsu TonyCTHsu added the dev/testing Involves testing processes (e.g. RSpec) label Nov 6, 2024
@sarahchen6 sarahchen6 merged commit 761daa4 into master Nov 6, 2024
263 checks passed
@sarahchen6 sarahchen6 deleted the sarahchen6/add-ruby-3.4-github branch November 6, 2024 16:05
@github-actions github-actions bot added this to the 2.6.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants