Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Nix Flake #4003

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Migrate to Nix Flake #4003

merged 6 commits into from
Oct 22, 2024

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented Oct 16, 2024

What does this PR do?

Migrate from classic Nix to Nix Flake.

Motivation:

  • flake.lock is much more potent than simply pinning pkgs by commit, like Gemfile.lock is for Ruby.
  • With evaluation caching, flakes are so much faster.

Additional Notes:

Backwards compatibility with classic nix-build and nix-shell is provided via flake-compat shims.

How to test the change?

  • nix flake show --all-systems
  • nix develop

@lloeki lloeki requested a review from a team as a code owner October 16, 2024 11:21
@lloeki lloeki force-pushed the lloeki/migrate-to-nix-flake branch 2 times, most recently from 1023c15 to e70f474 Compare October 16, 2024 11:35
Uses magic nix cache for faster results
@lloeki lloeki force-pushed the lloeki/migrate-to-nix-flake branch from e70f474 to 0f1dc1a Compare October 16, 2024 11:36
@pr-commenter
Copy link

pr-commenter bot commented Oct 16, 2024

Benchmarks

Benchmark execution time: 2024-10-22 12:30:31

Comparing candidate commit aebdbd1 in PR branch lloeki/migrate-to-nix-flake with baseline commit 9a012ec in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.86%. Comparing base (1f1afc1) to head (aebdbd1).
Report is 192 commits behind head on master.

Files with missing lines Patch % Lines
lib/datadog/core/telemetry/logging.rb 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4003      +/-   ##
==========================================
- Coverage   97.87%   97.86%   -0.01%     
==========================================
  Files        1313     1313              
  Lines       78352    78355       +3     
  Branches     3886     3886              
==========================================
+ Hits        76684    76686       +2     
- Misses       1668     1669       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lloeki lloeki merged commit 646cec2 into master Oct 22, 2024
252 checks passed
@lloeki lloeki deleted the lloeki/migrate-to-nix-flake branch October 22, 2024 13:09
@github-actions github-actions bot added this to the 2.5.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants