-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tracing): refactor web server integrations to use the core module #12035
base: main
Are you sure you want to change the base?
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 24.55s Total duration (35m 36.75s time saved) |
BenchmarksBenchmark execution time: 2025-01-24 21:36:23 Comparing candidate commit ee226aa in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 43.79s Total duration (36m 29.77s time saved) |
...pshots/tests.contrib.sanic.test_sanic_server.test_multiple_requests_sanic_http_pre_21.9.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 👏 👏
...pshots/tests.contrib.sanic.test_sanic_server.test_multiple_requests_sanic_http_pre_21.9.json
Show resolved
Hide resolved
tests/snapshots/tests.contrib.sanic.test_sanic_server.test_sanic_errors_pre_21.9.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions/nits but overall I love this change. Thanks for doing this clean up.
/merge |
Devflow running:
|
Motivation
Refactors all web server integrations still using
tracer.trace
to instead usecore.context_with_data
. This is in preparation for supporting AWS API Gateway to ensure all web servers share the same code path.Checklist
Reviewer Checklist