chore(ci): pin greenlet version to 3.1.0 for 3.8 [backport 2.19]
#11956
+40
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
## Context Failing tests slipped into the 2.19 branch, one of them being [this gevent test failure](https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/765798135). This was addressed in a fix PR to the main branch, and was [backported to 2.19](#11920). However, once backporting this fix, [ci_visibility tests on python 3.8 started to fail consistently](https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/765777070). After some digging, it turns out that in the backported fix for gevent, the [greenlet dependency was bumped from 3.0.3 to 3.1.1](https://github.com/DataDog/dd-trace-py/pull/11920/files#diff-939f705fbaed2d1386345b41d7c68406808ecbc5609022a59505453df9ba4b63), which according to greenlet documentation, [3.1.0 was the last release to support 3.7 and 3.8](https://greenlet.readthedocs.io/en/latest/changes.html#id2). Looks like pip didn't catch this during the upgrade because the [minimum runtime version is still pinned to 3.7 in greenlet](https://github.com/python-greenlet/greenlet/blob/3.1.1/setup.py#L263). ## Description This PR pins greenlet to 3.1.0 for python<=3.8, and will use latest for 3.9+. The failing ci_visibility tests will pass on 3.8 now. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 560aa89)
github-actions
bot
added
the
changelog/no-changelog
taegyunkim
approved these changes
Jan 15, 2025
|
|
BenchmarksBenchmark execution time: 2025-01-15 17:24:29 Comparing candidate commit a526500 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 393 metrics, 2 unstable metrics. scenario:iast_aspects-ospathdirname_aspect
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 560aa89 from #11953 to 2.19.
Context
Failing tests slipped into the 2.19 branch, one of them being this gevent test failure. This was addressed in a fix PR to the main branch, and was backported to 2.19. However, once backporting this fix, ci_visibility tests on python 3.8 started to fail consistently.
After some digging, it turns out that in the backported fix for gevent, the greenlet dependency was bumped from 3.0.3 to 3.1.1, which according to greenlet documentation, 3.1.0 was the last release to support 3.7 and 3.8. Looks like pip didn't catch this during the upgrade because the minimum runtime version is still pinned to 3.7 in greenlet.
Description
This PR pins greenlet to 3.1.0 for python<=3.8, and will use latest for 3.9+. The failing ci_visibility tests will pass on 3.8 now.
Checklist
Reviewer Checklist