Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): pin greenlet version for failing ci_visibility jobs with python 3.8 #11943

Closed
wants to merge 5 commits into from

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Jan 14, 2025

Context

Failing tests slipped into the 2.19 branch, one of them being this gevent test failure. This was addressed in a fix PR to the main branch, and was backported to 2.19. However, once backporting this fix, ci_visibility tests on python 3.8 started to fail consistently.

After some digging, it turns out that in the backported fix for gevent, the greenlet dependency was bumped from 3.0.3 to 3.1.1, which according to greenlet documentation, 3.1.0 was the last release to support 3.7 and 3.8. Looks like pip didn't catch this during the upgrade because the minimum runtime version is still pinned to 3.7 in greenlet.

Description

This PR pins greenlet to 3.1.0 for python<=3.8, and will use latest for 3.9+. The failing ci_visibility tests will pass on 3.8 now.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda changed the base branch from main to 2.19 January 14, 2025 21:41
Copy link
Contributor

github-actions bot commented Jan 14, 2025

CODEOWNERS have been resolved as:

.riot/requirements/1d4e95e.txt                                          @DataDog/apm-python
.riot/requirements/1b90fc9.txt                                          @DataDog/apm-python
.riot/requirements/61891b4.txt                                          @DataDog/apm-python
.riot/requirements/d171c08.txt                                          @DataDog/apm-python
.riot/requirements/de578a7.txt                                          @DataDog/apm-python
riotfile.py                                                             @DataDog/apm-python
.riot/requirements/6bec1ec.txt                                          @DataDog/apm-python

@pr-commenter
Copy link

pr-commenter bot commented Jan 14, 2025

Benchmarks

Benchmark execution time: 2025-01-14 23:29:56

Comparing candidate commit 521acb9 in PR branch erikayasuda/pin-greenlet-3.8 with baseline commit befc80b in branch 2.19.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@erikayasuda erikayasuda changed the title Erikayasuda/pin greenlet 3.8 chore(ci): pin greenlet version for failing ci_visibility jobs with python 3.8 Jan 14, 2025
@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 14, 2025
@erikayasuda erikayasuda changed the base branch from 2.19 to main January 14, 2025 22:49
@erikayasuda erikayasuda changed the base branch from main to 2.19 January 14, 2025 22:49
@erikayasuda erikayasuda marked this pull request as ready for review January 15, 2025 15:43
@erikayasuda erikayasuda requested a review from a team as a code owner January 15, 2025 15:43
@erikayasuda erikayasuda changed the base branch from 2.19 to main January 15, 2025 15:45
@erikayasuda erikayasuda requested review from a team as code owners January 15, 2025 15:45
@erikayasuda erikayasuda changed the base branch from main to 2.19 January 15, 2025 15:45
@erikayasuda
Copy link
Contributor Author

Closing this in favor of backporting this: #11953

The requirements files generated are pretty different, probably because I iterated a few times on this as a test branch. I'll do a clean backport and remediate any merge conflicts instead so future backports to 2.19 aren't messed up.

@erikayasuda erikayasuda deleted the erikayasuda/pin-greenlet-3.8 branch January 15, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants