-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): pin greenlet
version for failing ci_visibility jobs with python 3.8
#11943
Conversation
|
BenchmarksBenchmark execution time: 2025-01-14 23:29:56 Comparing candidate commit 521acb9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
greenlet
version for failing ci_visibility jobs with python 3.8
Closing this in favor of backporting this: #11953 The requirements files generated are pretty different, probably because I iterated a few times on this as a test branch. I'll do a clean backport and remediate any merge conflicts instead so future backports to 2.19 aren't messed up. |
Context
Failing tests slipped into the 2.19 branch, one of them being this gevent test failure. This was addressed in a fix PR to the main branch, and was backported to 2.19. However, once backporting this fix, ci_visibility tests on python 3.8 started to fail consistently.
After some digging, it turns out that in the backported fix for gevent, the greenlet dependency was bumped from 3.0.3 to 3.1.1, which according to greenlet documentation, 3.1.0 was the last release to support 3.7 and 3.8. Looks like pip didn't catch this during the upgrade because the minimum runtime version is still pinned to 3.7 in greenlet.
Description
This PR pins greenlet to 3.1.0 for python<=3.8, and will use latest for 3.9+. The failing ci_visibility tests will pass on 3.8 now.
Checklist
Reviewer Checklist