Add github CI/CD setup #5
Conversation
nsavoire
force-pushed
the
nsavoire/ci_setup
branch
6 times, most recently
from
517d5a0 to
f636d00
Compare
nsavoire
force-pushed
the
nsavoire/ci_setup
branch
from
dee944c to
67bec15
Compare
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| RUN apt-get update && \ | ||
| apt-get install -y --no-install-recommends binutils ca-certificates |
There was a problem hiding this comment.
⚪ Code Quality Violation
package binutils should have version pinned (...read more)
When using apt-get install, pin the version to avoid unwanted upgrades and undefined behavior.
nsavoire
force-pushed
the
nsavoire/ci_setup
branch
7 times, most recently
from
f0952dd to
83f3514
Compare
nsavoire
force-pushed
the
nsavoire/ci_setup
branch
from
83f3514 to
c6f010f
Compare
* release: build multi-arch docker image * docker: add entrypoint that mounts debugfs if it's not mounted
nsavoire
force-pushed
the
nsavoire/ci_setup
branch
from
c6f010f to
0c077a6
Compare
| ) | ||
|
|
||
| // Assert that we implement the full Reporter interface. | ||
| var _ reporter.Reporter = (*DatadogReporter)(nil) | ||
|
|
||
| const profilerName = "dd-otel-profiling-agent" | ||
| const profilerName = "dd-opentelemetry-profiler" |
There was a problem hiding this comment.
@nsavoire We will need to update the code in the backend to reflect this change. Do you mind following up or adding a card to track this 🙇 ?
There was a problem hiding this comment.
Scratch that, no need to since we didn't hard code the name there: https://github.com/DataDog/profiling-backend/blob/d49c6c55069d5b09e1ce7058b9a13605dedebc47/prof-analyzer/src/main/java/com/datadog/profiling/analyzer/stages/ReportingStage.java#L285-L290 all good!
There was a problem hiding this comment.
Still, there are lot places where we are using (dd-)otel-profiling-agent as repository or executable name and that will need to be updated.
There was a problem hiding this comment.
| @@ -4,6 +4,9 @@ | |||
| * See the file "LICENSE" for details. | |||
There was a problem hiding this comment.
Was it intentional to leave the old copyright here?
There was a problem hiding this comment.
Yes, because it's based on cli_flags.go from opentelemetry-ebpf-profiler.
I also added Datadog copyright because we modified it (same for helpers.go and some other files).
| - name: Check out | ||
| uses: actions/checkout@v4 | ||
| - name: golangci-lint | ||
| uses: reviewdog/action-golangci-lint@v2 |
There was a problem hiding this comment.
Any reason not to use the official golangci/golangci-lint-action ?
There was a problem hiding this comment.
That's what dd-trace-go is using and since I don't have much experience with Go, I figured they knew what they are doing 😄
First version of github CI (heavily inspired by dd-trace-go):