-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DC-1205]Store TDR owned Sam Group info in database #1788
Conversation
…senting the sam group
…o contain sam group information
…hotIdAndSamGroupToSnapshotRequestStep
…ed on the snapshot access request that created the snapshot
# Conflicts: # src/main/java/bio/terra/service/snapshot/flight/create/SnapshotCreateFlight.java # src/test/java/bio/terra/service/snapshot/SnapshotServiceTest.java # src/test/java/bio/terra/service/snapshot/flight/create/SnapshotCreateFlightTest.java # src/test/java/bio/terra/service/snapshotbuilder/SnapshotBuilderServiceTest.java
src/main/java/bio/terra/service/snapshot/flight/create/AddCreatedInfoToSnapshotRequestStep.java
Outdated
Show resolved
Hide resolved
src/main/java/bio/terra/service/snapshot/flight/delete/DeleteSnapshotDeleteSamGroupStep.java
Outdated
Show resolved
Hide resolved
src/main/java/bio/terra/service/snapshot/flight/delete/DeleteSnapshotDeleteSamGroupStep.java
Outdated
Show resolved
Hide resolved
src/main/java/bio/terra/service/snapshot/flight/create/SnapshotCreateFlight.java
Outdated
Show resolved
Hide resolved
src/test/java/bio/terra/service/snapshotbuilder/SnapshotBuilderTestData.java
Show resolved
Hide resolved
src/test/java/bio/terra/service/snapshotbuilder/SnapshotRequestDaoTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done, still looking at the test code
src/main/java/bio/terra/service/snapshot/flight/create/AddCreatedInfoToSnapshotRequestStep.java
Outdated
Show resolved
Hide resolved
src/main/java/bio/terra/service/snapshot/flight/create/AddCreatedInfoToSnapshotRequestStep.java
Outdated
Show resolved
Hide resolved
src/main/java/bio/terra/service/snapshot/flight/delete/DeleteSnapshotDeleteSamGroupStep.java
Outdated
Show resolved
Hide resolved
src/main/java/bio/terra/service/snapshot/flight/delete/DeleteSnapshotDeleteSamGroupStep.java
Outdated
Show resolved
Hide resolved
...test/java/bio/terra/service/snapshot/flight/delete/DeleteSnapshotDeleteSamGroupStepTest.java
Outdated
Show resolved
Hide resolved
...t/java/bio/terra/service/snapshot/flight/delete/DeleteSnapshotPopAndLockDatasetStepTest.java
Outdated
Show resolved
Hide resolved
src/test/java/bio/terra/service/snapshotbuilder/SnapshotRequestDaoTest.java
Outdated
Show resolved
Hide resolved
src/test/java/bio/terra/service/snapshotbuilder/SnapshotRequestDaoTest.java
Show resolved
Hide resolved
src/test/java/bio/terra/service/snapshotbuilder/SnapshotRequestDaoTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/resources/db/changelog.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, one last comment or two
src/main/java/bio/terra/service/snapshot/flight/create/AddCreatedInfoToSnapshotRequestStep.java
Outdated
Show resolved
Hide resolved
src/main/java/bio/terra/service/snapshot/flight/delete/DeleteSnapshotDeleteSamGroupStep.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Phil's last couple of comments, but otherwise LGTM.
src/main/java/bio/terra/service/snapshot/flight/delete/DeleteSnapshotPopAndLockDatasetStep.java
Show resolved
Hide resolved
src/main/java/bio/terra/service/snapshot/flight/create/AddCreatedInfoToSnapshotRequestStep.java
Outdated
Show resolved
Hide resolved
|
Jira ticket: https://broadworkbench.atlassian.net/browse/DC-1205
Summary of changes
Testing Strategy