TA & TC Factory Method Abstraction #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bieryAtFnal
added
the
miscellaneous deliverable
|
LGTM, more comments in the trigger PR (DUNE-DAQ/trigger#257). |
ArturSztuc
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
LGTM. Could add some error messages as above, but not important for now.
Should present the AbstractFactory somewhere, and ask Core software people where to move it -- it's generic enough that could be useful for other repositories/groups, but again, that would come in a separate PR in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factory design pattern for TA Makers was shifted to an abstract factory and extended for TC Makers. At the same time,
shared_ptrs were changed tounique_ptrs and redundant includes mentioned in #55 were removed.This was tested on
tpstream_writing_testin daqsystemtest and requires the related feature branch intrigger.