Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PlaneCoincidence PyBind #44

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Add PlaneCoincidence PyBind #44

merged 1 commit into from
Sep 13, 2024

Conversation

aeoranday
Copy link
Member

@aeoranday aeoranday commented Sep 11, 2024 •
edited
Loading

Added the missing kPlaneCoincidence python binding for TriggerActivity algorithms. Closes #43.

Testing was done as

import trgdataformats
print(trgdataformats.TriggerActivityData.Algorithm(7))

before and after this change.

On the before case, it should print Algorithm.???. On the after, Algorithm.kPlaneCoincidence.

@aeoranday aeoranday added the maintenance Addresses a user request or a change in another part of the system label Sep 11, 2024
@aeoranday aeoranday self-assigned this Sep 11, 2024
MRiganSUSX
MRiganSUSX approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@MRiganSUSX MRiganSUSX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aeoranday aeoranday merged commit 24ddd2c into develop Sep 13, 2024
2 checks passed
@aeoranday aeoranday deleted the aeo/missing-ta-pybind branch September 13, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRiganSUSX MRiganSUSX MRiganSUSX approved these changes

@ArturSztuc ArturSztuc Awaiting requested review from ArturSztuc

Assignees

@aeoranday aeoranday

Labels
maintenance Addresses a user request or a change in another part of the system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeoranday @MRiganSUSX