TPG Threshold By Plane #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeoranday
added
maintenance
alessandrothea
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the new TPG threshold by plane implementation in fdreadoutlibs. Running any of
wibeth_tpg_validation,wibeth_tpg_workload_emulator, orwibeth_tpg_algorithms_emulatornow include the option to specify the thresholds for each plane. If a plane's threshold is not specified, it defaults to the general TPG threshold value.Testing was limited with this implementation because the emulators prepare thresholds according to the first WIBEth frame seen. Expanding to use thresholds for all frames still has issues: TPs which do not complete by the end of a WIBEth fragment are left "above threshold" until the next fragment and instead mark the new fragment as having a TP. This frequently resulted in incorrect channels appearing above threshold and confounds the result of the threshold by plane.
The solution for how to process WIBEth frames and emulate effectively seems outside the scope of this PR.