Replace pytest-results-action with a custom xml parser script
#417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated due to the #418 merge. Merge branch 'develop' into amogan/integtest_markdown_parser
jcfreeman2
reviewed
Jan 7, 2025
There was a problem hiding this comment.
The output of the integration tests is much easier on the eyes and a lot clearer. A comment and a question:
- The merge of PR Extend nightly integration tests to work on candidate or frozen builds #418 into
developresulted in a divergence which I fixed by mergingdevelopinto this PRs feature branch and then resolving a couple of conflicts via commit c5f7a72. - It's a nitpick, but in the old method of presentation the number of total tests presented and their breakdown into passes and fails was prevented; would it be hard to bring this back? Something like "62 tests passed, 2 tests failed" at the very bottom of the output.
…tables" step of the nightly integration tests
|
Added a summary line at the top: https://github.com/DUNE-DAQ/daq-release/actions/runs/12654961917 |
|
Looks great; approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current nightly integration test workflow uses a pytest-results-action, a barely maintained GitHub action that creates a summary table of pytest results. What's more, we don't even use the
mainbranch of that action, but a fork I made to slightly improve the table formatting for our purposes. Rather than rely on a barely maintained fork of a barely maintained third party action, this PR introduces a python script underscripts/github-cito achieve a similar result while allowing greater flexibility and removing a third party dependency. Similar to our nightly code check workflow, this script creates a markdown summary file which is then added toGITHUB_STEP_SUMMARY. Sample results are linked below.Sample v5 results
Sample v4 results