migrate to typescript #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massfords
commented
Jan 7, 2025
| # DQL | ||
| # DLQ |
There was a problem hiding this comment.
Typo in the README
massfords
commented
Jan 7, 2025
Comment on lines
+3
to
5
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-expect-error | ||
| import mergeRace from "@async-generator/merge-race"; |
There was a problem hiding this comment.
there are no types for this lib.
Should we continue to use this? Is there an alternative to this merge-race?
There was a problem hiding this comment.
There are some suggested, manual, solution here
There was a problem hiding this comment.
Better not use yet another npm that will have more dependabot updates, and eventually not maintained
massfords
commented
Jan 7, 2025
Comment on lines
-103
to
-105
| sqs: AWS.SQS, | ||
| FunctionName: string, | ||
| QueueUrl: string, |
There was a problem hiding this comment.
I removed the sqs and QueueUrl params since they weren't used
massfords
commented
Jan 7, 2025
| sqs: AWS.SQS, | ||
| QueueUrl: string, |
There was a problem hiding this comment.
QueueUrl was not referenced
massfords
commented
Jan 7, 2025
| lambda: AWS.Lambda, | ||
| sqs: AWS.SQS, | ||
| queueUrl: string, |
There was a problem hiding this comment.
queueUrl was removed as a result of it being removed from the redrive funcs below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What does this PR do?