fix: adding multiple signatures on metagraph messages #63
Conversation
| @@ -197,7 +197,7 @@ | |||
| shell: | | |||
| rm -f /home/{{ ansible_user }}/code/{{ all_nodes[0].key_file.name }} | |||
|
|
|||
| - name: Send fees p12 files to nodes | |||
| - name: Send primary fees p12 files to nodes | |||
There was a problem hiding this comment.
| - name: Send primary fees p12 files to nodes | |
| - name: Send primary snapshot fee p12 file to nodes |
| when: not (staking_p12_file_name is undefined or staking_p12_file_name == "") and staking_p12_file.stat.exists | ||
|
|
||
| - name: Send additional fees p12 files to nodes |
There was a problem hiding this comment.
| - name: Send additional fees p12 files to nodes | |
| - name: Send snapshot fee p12 file to additional nodes |
| @@ -69,6 +69,17 @@ | |||
| msg: "File /home/{{ ansible_user }}/code/metagraph-l0/{{ owner_p12_file_name }} does not exist" | |||
| when: not (owner_p12_file_name is undefined or owner_p12_file_name == "") and not owner_file.stat.exists | |||
|
|
|||
| - name: Check if additional owner file exists | |||
There was a problem hiding this comment.
What's the additional owner file? Isn't there just one file that represents the owner?
There was a problem hiding this comment.
The name wasn't good enough, it's just a second file to sign the message and this file should be one of the 3 peerIds, I'll rename to be more clear, sorry
| @@ -247,9 +325,9 @@ | |||
| ignore_errors: true | |||
| when: should_run_genesis | |||
|
|
|||
| - name: Wait 2 minutes before starting the metagraph | |||
| - name: Wait 10 minutes before starting the metagraph | |||
There was a problem hiding this comment.
10 minutes seems like a long time. Why do we need to wait that long?
There was a problem hiding this comment.
I forgot to change, it can be only 5. We need at least 5 so network can proceed without the metagraph a bit and we have a period where we can send the messages before producing snapshots
@AlexBrandes This follows the current flow of remote-deploy and remote-start, so users won’t need to take any additional steps. The goal of this ticket is to automate the process of generating the second signature. When the feature was first released (at least on testnet and integrationnet), a single signer was sufficient to send the message. However, with the recent changes, a majority signature is required for the message to be valid. This ticket handles the generation of the second signature and attaches it to the current message/JSON before sending. |
IPadawans
force-pushed
the
adding-multiple-signatures-messages
branch
from
e4b3d54 to
cc6170c
Compare
Changes