Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ASE-based espresso parser from medford-group #47

Open
wants to merge 39 commits into
base: develop
Choose a base branch
from

Conversation

maxhutch
Copy link
Contributor

All I've done so far is branch of medford-group/espresso and merge in CitrineInformatics/develop, resolving the conflicts. This probably won't work yet, but opening the PR will get travis tests going.

CC: @ajmedford

@ajmedford
Copy link

Thanks Max! We didn't quite get this buttoned up last time we worked on it, but plan to put some more effort in before the end of summer. Having the CI tests will help give us something to shoot for. I believe our GPAW parser is also in this branch, so it may need to be renamed in the future. We can cross that bridge when we get there.

@maxhutch
Copy link
Contributor Author

maxhutch commented Aug 1, 2017

@ajmedford I have some cycles to put into the QE parser this week and the next. I was going to just pick out your ase-based parser and either combine it with the existing parser or replace it outright. If you'd like, we could sync up on what your opens are try to get your group supported from the main branch again.

wrt GPAW: it looks like there is some stuff in the examples, but no parser

@ajmedford
Copy link

@maxhutch Sounds good - It looks like the GPAW parser is actually in another (student) repo so we can merge that in later.

I think having an ase-espresso parser is a good idea, but I think it might be a good idea to separate the "ASE" part and the espresso-specific parts. The former is probably much more impactful, especially since you already have a PWscf parser. It might be worth looking at Kitchin's ASE-mongo implementation too. Having a way to easily put an ASE atoms object (and its associated calculator parameters) into a .pif file would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants