[TAN-3658] Add new not_reactable_status_code reason to deny reacting_idea #10197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@jinjagit You can revert the FE changes in this PR. I'll open a separate PR. |
jamesspeake
approved these changes
Feb 3, 2025
back/spec/services/permissions/idea_permissions_service_spec.rb
Outdated
Show resolved
Hide resolved
Done. Thanks! |
jinjagit
changed the title
brentguf
reviewed
Feb 4, 2025
back/app/models/idea_status.rb
Outdated
| @@ -19,6 +19,7 @@ class IdeaStatus < ApplicationRecord | |||
| CODES = %w[prescreening proposed threshold_reached expired viewed under_consideration accepted implemented rejected answered ineligible custom].freeze | |||
| LOCKED_CODES = %w[prescreening proposed threshold_reached expired].freeze | |||
| MANUAL_TRANSITION_NOT_ALLOWED_CODES = %w[prescreening threshold_reached expired].freeze | |||
| REACTING_NOT_ALLOWED_CODES = %w[expired ineligible].freeze | |||
There was a problem hiding this comment.
Should we include prescreening?
There was a problem hiding this comment.
I've added it in, but it might be YAGNI as an idea with a prescreening status can't have a publication_status: 'published', so it's unlikely anyone (other than admins, mods & author) can see the idea to vote on it.
…into TAN-3658-prevent-voting-on-proposal-with-specific-status-codes
…s-codes' of https://github.com/CitizenLabDotCo/citizenlab into TAN-3658-prevent-voting-on-proposal-with-specific-status-codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BE code only, at this point.
Changelog
Technical
not_reactable_status_codereason to denyreacting_idea. To be used to prevent voting on a proposal with prescreening, expired or ineligible status (including in mobile view)