Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AskFileButton can now upload file with proper checking and it's own limits #1911

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: AskFileButton can now upload file with proper checking and it's own limits #1911

wants to merge 1 commit into from

Conversation

pmercier
Copy link
Contributor

@pmercier pmercier commented Feb 19, 2025 •
edited
Loading

This a follow up of #1658.

This PR solve :

  • the validate_file_upload() that prevented uploading file with AskFileMessage when spontaneous_file_upload was set to False
  • the POST /project/file will now validate the upload against the AskFileMessage limit/accept instead of the spontaneous upload limit/accept

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. backend Pertains to the Python backend. frontend Pertains to the frontend. labels Feb 19, 2025
@pmercier pmercier changed the title fix: AskFileButton can now upload file with proper checking and it's … fix: AskFileButton can now upload file with proper checking and it's own limits Feb 19, 2025
@pmercier
Copy link
Contributor Author

Currently working on failed tests

@pmercier pmercier force-pushed the fix-differentiated_uploads branch from a7dc754 to 3f9947e Compare February 19, 2025 15:30
@pmercier pmercier force-pushed the fix-differentiated_uploads branch from 3f9947e to 93e1dfe Compare February 19, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend Pertains to the Python backend. frontend Pertains to the frontend. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pmercier