Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke site resource when pod vm creation is failed #298

Closed
wants to merge 15 commits into from

Conversation

kimeunju108
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR proposes to withdraw site (cluster) resource allocated to a pod when the pod's vm creation is failed.

Which issue(s) this PR fixes:
Fixes #286

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

How to test?:
~/go/src/k8s.io/arktos$./hack/globalscheduler/globalscheduler-up.sh
open a new terminal
cd ~/go/src/k8s.io/arktos/globalscheduler/test/yaml
kubectl apply -f sample_6_clusters.yaml
kubectl apply -f sample_2_schedulers.yaml
kubectl apply -f sample_2_distributors.yaml
kubectl apply -f sample_2_dispatchers.yaml
kubectl apply -f sample_6_pods.yaml
kubectl get pods

@jshaofuturewei
Copy link
Collaborator

Is it a new PR? I have not found any previous comments.

@kimeunju108
Copy link
Collaborator Author

kimeunju108 commented May 25, 2021

Is it a new PR? I have not found any previous comments.

Yes, this is new PR with #298. The original PR 289 had an issue to update in CICD pass as we discussed last week. I could not update the same PR.
Your reviews are in the follwoing link and I answered most of them.
#289

@jshaofuturewei
Copy link
Collaborator

Is it a new PR? I have not found any previous comments.

Yes, this is new PR with #298. The original PR 289 had an issue to update in CICD pass as we discussed last week. I could not update the same PR.
Your reviews are in the follwoing link and I answered most of them.
#289

Please reopen the #289 and its CICD issue has been resolved. My PR #288 works total fine now.

@kimeunju108
Copy link
Collaborator Author

kimeunju108 commented May 25, 2021

Is it a new PR? I have not found any previous comments.

Yes, this is new PR with #298. The original PR 289 had an issue to update in CICD pass as we discussed last week. I could not update the same PR.
Your reviews are in the follwoing link and I answered most of them.
#289

Please reopen the #289 and its CICD issue has been resolved. My PR #288 works total fine now.

I tried to reopen but it is not possible unfortunately. open button is inactivated.

@kimeunju108 kimeunju108 reopened this May 25, 2021
@kimeunju108 kimeunju108 reopened this May 25, 2021
@kimeunju108 kimeunju108 deleted the feature/resource branch May 25, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revoke cluster resources when scheduling failed to create a vm
2 participants