Skip to content
This repository was archived by the owner on May 24, 2024. It is now read-only.

Fedora ELN compose as a dependency #127

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

lmilbaum
Copy link
Contributor

@lmilbaum lmilbaum commented Jan 12, 2024

Renovate would identify new fedora eln compose and will raise a PR

@lmilbaum lmilbaum self-assigned this Jan 12, 2024
@lmilbaum lmilbaum marked this pull request as ready for review January 12, 2024 19:57
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. That's some renovate sorcery.

One point of note here is that composes are currently subject to GC, so if we don't merge then builds will relatively quickly (I think within a week) start failing...which goes very much into the "lock container builds with composes" thread.

Also strongly related to this, now that we're doing this, it'd make sense to propagate the compose version into our container image (both /etc/os-release and the standard OCI version key)...although we may need some extra versioning component in case just something here changes...another fun twist.

Anyways this is all optional followup, I think this approach makes sense!

@lmilbaum
Copy link
Contributor Author

Neat. That's some renovate sorcery.

One point of note here is that composes are currently subject to GC, so if we don't merge then builds will relatively quickly (I think within a week) start failing...which goes very much into the "lock container builds with composes" thread.

Also strongly related to this, now that we're doing this, it'd make sense to propagate the compose version into our container image (both /etc/os-release and the standard OCI version key)...although we may need some extra versioning component in case just something here changes...another fun twist.

Anyways this is all optional followup, I think this approach makes sense!

Thanks @cgwalters I pushed some changes such that Renovate opens a PR for this deps as soon as new version available and auto merge it if CI is green. Would you mind filing issues for the additional requirements?

@lmilbaum
Copy link
Contributor Author

/retest

@lmilbaum lmilbaum merged commit 9b35a3c into CentOS:main Jan 16, 2024
@lmilbaum lmilbaum deleted the fedora-eln-compose branch January 16, 2024 05:45
@cgwalters
Copy link
Member

I like the idea of this, but we are definitely already hitting GC issues in other PRs:

error: Updating rpm-md repo 'eln-baseos': cannot update repo 'eln-baseos': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried; Last error: Status code: 404 for https://odcs.fedoraproject.org/composes/production/Fedora-ELN-20240114.5/compose/BaseOS/x86_64/os/repodata/repomd.xml (IP: 140.211.169.196)

It looks like the GC threshold is about a day, which means unless we merge these renovate bot PRs quickly, we'll just end up with dead CI.

And again this goes right into the deeper problem that we need to move farther upstream to have effective CI and integration.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants