-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated 2025 Q1 Release Notes to Reflect Partial J2735 2024 Compatibility #159
Updated 2025 Q1 Release Notes to Reflect Partial J2735 2024 Compatibility #159
Conversation
…lity with J2735 2024 Signed-off-by: dmccoystephenson <dmccoystephenson@gmail.com>
Signed-off-by: dmccoystephenson <dmccoystephenson@gmail.com>
docs/Release_notes.md
Outdated
Schema updates have been implemented to increment the version of output messages and provide partial compatibility with | ||
J2735 2024. However, some limitations remain. Due to a bug in the ASN.1 Compiler, the VehicleEventFlags bitstring has | ||
been reverted to its 2020 version, excluding the eventJackKnife bit introduced in the 2024 revision. As a result, this | ||
bit will not appear in output BSMs until the issue is resolved. Additionally, certain fields added to BSM-related |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than "certain fields" should we make it clear this is all newly added fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Otherwise we should probably document which fields or make a hyperlink to which fields and document it elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed! Modified to the following:
Additionally, new fields added to BSM-related structures in J2735 2024 are not yet supported in the ODE. These fields—such as fhwaVehicleClass, trailers, and schoolBus for SupplementalVehicleExtensions, as well as trailerPresent, pivotPoint, axles, and leanAngle for VehicleData—will be incorporated in a future release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one comment. Looks good, approving with suggestion!
docs/Release_notes.md
Outdated
Schema updates have been implemented to increment the version of output messages and provide partial compatibility with | ||
J2735 2024. However, some limitations remain. Due to a bug in the ASN.1 Compiler, the VehicleEventFlags bitstring has | ||
been reverted to its 2020 version, excluding the eventJackKnife bit introduced in the 2024 revision. As a result, this | ||
bit will not appear in output BSMs until the issue is resolved. Additionally, certain fields added to BSM-related |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Otherwise we should probably document which fields or make a hyperlink to which fields and document it elsewhere.
Signed-off-by: dmccoystephenson <dmccoystephenson@gmail.com>
Signed-off-by: dmccoystephenson <dmccoystephenson@gmail.com>
Signed-off-by: dmccoystephenson <dmccoystephenson@gmail.com>
Signed-off-by: dmccoystephenson <dmccoystephenson@gmail.com>
…PATs, MAPs & TIMs Signed-off-by: dmccoystephenson <dmccoystephenson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
PR Details
Description
This pull request updates the 2025 Q1 release notes to reflect changes made for partial compatibility with J2735 2024. Schema updates have been implemented to increment the version of output messages. However, due to a bug in the ASN.1 Compiler, the VehicleEventFlags bitstring has been reverted to its 2020 version, meaning the new eventJackKnife bit from the 2024 revision will not appear in output BSMs until the issue is resolved. Additionally, some new fields introduced in J2735 2024 for BSM-related structures are not yet supported in the ODE but will be included in a future release.
Related Issue
No related GitHub issue.
Motivation and Context
J2735 2024 includes updates that require changes to message structures, and we’ve made progress in supporting these updates. While there are some known limitations, like the missing eventJackKnife bit and unsupported fields, this update provides clarity about the current state of compatibility. The goal is to keep users informed about what’s available now and what will be included in future releases.
How Has This Been Tested?
Documentation change, no testing necessary.
Types of changes
Checklist:
ODE Contributing Guide