Enhance dialog responsiveness #268
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Describe the changes you have made in this PR -
Improved the responsiveness of dialogs in create_join_dialog.dart to better adapt across screen sizes.
-Replaced fixed heights (e.g., 30.h, 25.h, 12.h) with mainAxisSize: MainAxisSize.min
-Updated padding from fixed values (EdgeInsets.symmetric(horizontal: 32, vertical: 16)) to percentage-based (EdgeInsets.symmetric(horizontal: 8.w, vertical: 2.h)) for consistent scaling
-Removed unnecessary Container wrappers to streamline the layout
Screenshots of the changes (If any) -
Due to Gradle build issues, I couldn’t generate screenshots. The changes are untested but based on static analysis.
Expected outcome: dialogs now resize dynamically without truncation, with consistent padding and button sizes across devices.
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.