Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wood harvest/products pool parameters to namelist file #549

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tammasloughran
Copy link
Collaborator

@tammasloughran tammasloughran commented Feb 20, 2025

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

The wood harvest/products parameters are hard coded into the CABLE-ACCESS interface. There is no technical reason to have these parameters hard coded and they are important for tuning the land use change/thinning components to get reasonable land-use emissions. I will move them into the CABLE namelist file.

These parameters are:

REAL :: pool_frac(3) = (/0.33,0.33,0.34/) !! Fraction of harvested biomass allocated to the wood products pools
REAL :: pool_time(3) = (/1.00,0.10,0.01/) !! Timescale of wood product pool decay to the atmosphere (year^-1)

Fixes #548

Type of change

Please delete options that are not relevant.

  • New or updated documentation

Checklist

  • The new content is accessible and located in the appropriate section
  • I have checked that links are valid and point to the intended content
  • I have checked my code/text and corrected any misspellings

Testing

  • Are the changes bitwise-compatible with the main branch? If working on an optional feature, are the results bitwise-compatible when this feature is off? If yes, copy benchcab output showing successful completion of the bitwise compatibility tests or equivalent results below this line.

  • Are the changes non bitwise-compatible with the main branch because of a bug fix or a feature being newly implemented or improved? If yes, add the link to the modelevaluation.org analysis versus the main branch or equivalent results below this line.

Please add a reviewer when ready for review.


📚 Documentation preview 📚: https://cable--549.org.readthedocs.build/en/549/

@tammasloughran tammasloughran linked an issue Feb 20, 2025 that may be closed by this pull request
@tammasloughran
Copy link
Collaborator Author

I just noticed that the namelist code is different in the CABLE repository and the UM7 repository. I might need to rethink this.

https://github.com/ACCESS-NRI/UM7/pull/75#issuecomment-2677219050

@tammasloughran tammasloughran marked this pull request as draft February 24, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wood harvest/products parameters to CABLE namelist file.
1 participant