make product string in HID descriptor and the platform value in the REQ_INFO dynamic, not hardcoded #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the main usb_desc.h smaller, with the goal if copy/pasting it once per platform (BitBox02 and BitBox02 Plus) to add new product strings for BitBox02 Plus.
For the time being we intend to have one firmware per edition targetting both BB02 and BB02-Plus. For this reason we add a memory flag to store which platform it is (BB02 vs BB02-Plus), and make the USB HID descriptor product string dynamic dependent on that. Since our descriptor bytes are built from macros, this commit does a quick solution by copy pasting the descriptor and changing only the product string. In the future we can consider building the descriptor bytes in normal code which would make setting the product string easier.
Based on the newly added memory flag.
benma
force-pushed
the
bb02p-product-string
branch
from
cf65558 to
98a2142
Compare
This also introduces new signed firmware magic headers, chosen randomly.
benma
force-pushed
the
bb02p-product-string
branch
from
98a2142 to
574d85b
Compare
benma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1370
Allows us to have one firmware (per edition) for both bb02 and bb02-plus while still allowing the client to differentiate between them.