Adding explicit build-args for linux amd64 #1369
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to build the latest firmware, the
TARGETPLATFORM
andTARGETARCH
were not being automatically populated from the--platform linux/amd64
as assumed here:https://github.com/BitBoxSwiss/bitbox02-firmware/blob/master/Dockerfile#L24
This lead to confusing errors late in the build process.
Docker indicates these AARGs are only set when using the buildkit backend: https://docs.docker.com/reference/dockerfile/#automatic-platform-args-in-the-global-scope
I'm using docker commandline, on PopOS.
In order to prevent issues for myself and other users, I am making this PR to explicitly set these parameters instead of relying on invisible buildkit magic.