[공지사항] 코인 공지사항 구현 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junghaesung79
requested review from
ChoiWonBeen and
hanagertrudeKim
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
MinGu-Jeong
reviewed
Oct 7, 2024
Comment on lines
46
to
48
| const debouncedSetFieldsValue = useDebounce(useCallback((value: string) => { | ||
| form.setFieldsValue({ content: value }); | ||
| }, [form]), 300); |
There was a problem hiding this comment.
handleFinish 함수를 완성하지 전에 생각하기로 form이 바뀌는 것을 핸들링 해야 한다고 생각했었습니다. 지금 확인해보니 onChange 이벤트를 주지 않고 debounce 관련 코드를 전부 걷어내도 정상적으로 기능하네요. 이 부분 수정하겠습니다.
MinGu-Jeong
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
코인 자체 공지사항 기능 구현했습니다.
현재 공지사항 수정 후 그 본문이 즉시 반영되지 않는 문제가 있습니다.해결 시도해보고 마땅한 방법을 못 찾을 경우 제출 후 새로고침 하는 방법을 사용할 생각입니다.