Add support for snaps #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng environments Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
Co-authored-by: Micah Lewis <1009123+micahl@users.noreply.github.com>
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
Co-authored-by: Micah Lewis <1009123+micahl@users.noreply.github.com>
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
The aziotctl_common::config::write_file function first changes ownership of a file, then changes the permissions. Changing the permissions on a file owned by another user requires CAP_FOWNER. While this is not normally a problem for root, the assumption that root ALWAYS has CAP_FOWNER is erroneous (snaps are a counter example). This commit simply reorders the operation, so that the file is still owned by the creator when the permissions get changed. Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com> Co-authored-by: Damon Barry <damonb@microsoft.com>
migrate to base: core22. this also entails a slight shift in snapcraft syntax (mostly documented [here](https://forum.snapcraft.io/t/micro-howto-migrate-from-core20-to-core22/30188), plus filesets no longer supported) --------- Signed-off-by: Alex Lewontin <alex.c.lewontin@gmail.com> Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
A slight fix above and beyond #583 Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
arsing
approved these changes
Feb 29, 2024
damonbarry
added a commit
to damonbarry/iot-identity-service
that referenced
this pull request
Mar 1, 2024
This change updates the repo to support building IoT Identity Service components as snaps. One of the main differences with snaps is that they run in a tightly confined sandbox, so many hard-coded references to users and filesystem paths had to be adapted to support compile-time variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the repo to support building IoT Identity Service components as snaps. One of the main differences with snaps is that they run in a tightly confined sandbox, so many hard-coded references to users and filesystem paths had to be adapted to support compile-time variables.