tool: validator script for Azure NPM to Cilium migration #14800
rayaisaiahAnnotations
24 errors and 4 warnings
|
Lint (1.23.x, ubuntu-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L83
paramTypeCombine: func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithEndport []string, egressPoliciesWithEndport []string) could be replaced with func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithEndport, egressPoliciesWithEndport []string) (gocritic)
|
|
Lint (1.23.x, ubuntu-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L115
paramTypeCombine: func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithCIDR []string, egressPoliciesWithCIDR []string) could be replaced with func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithCIDR, egressPoliciesWithCIDR []string) (gocritic)
|
|
Lint (1.23.x, ubuntu-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L165
paramTypeCombine: func(namespaces *corev1.NamespaceList, servicesByNamespace map[string][]*corev1.Service, policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (unsafeServices []string, noSelectorServices []string) could be replaced with func(namespaces *corev1.NamespaceList, servicesByNamespace map[string][]*corev1.Service, policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (unsafeServices, noSelectorServices []string) (gocritic)
|
|
Lint (1.23.x, ubuntu-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L253
ptrToRefParam: consider `serviceLabels' to be of non-pointer type (gocritic)
|
|
Lint (1.23.x, ubuntu-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L201
naked return in func `getExternalTrafficPolicyClusterServices` with 37 lines of code (nakedret)
|
|
Lint (1.23.x, ubuntu-latest)
issues found
|
|
Lint (1.23.x, windows-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L83
paramTypeCombine: func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithEndport []string, egressPoliciesWithEndport []string) could be replaced with func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithEndport, egressPoliciesWithEndport []string) (gocritic)
|
|
Lint (1.23.x, windows-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L115
paramTypeCombine: func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithCIDR []string, egressPoliciesWithCIDR []string) could be replaced with func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithCIDR, egressPoliciesWithCIDR []string) (gocritic)
|
|
Lint (1.23.x, windows-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L165
paramTypeCombine: func(namespaces *corev1.NamespaceList, servicesByNamespace map[string][]*corev1.Service, policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (unsafeServices []string, noSelectorServices []string) could be replaced with func(namespaces *corev1.NamespaceList, servicesByNamespace map[string][]*corev1.Service, policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (unsafeServices, noSelectorServices []string) (gocritic)
|
|
Lint (1.23.x, windows-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L253
ptrToRefParam: consider `serviceLabels' to be of non-pointer type (gocritic)
|
|
Lint (1.23.x, windows-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L201
naked return in func `getExternalTrafficPolicyClusterServices` with 37 lines of code (nakedret)
|
|
Lint (1.23.x, windows-latest)
issues found
|
|
Lint (1.22.x, ubuntu-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L83
paramTypeCombine: func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithEndport []string, egressPoliciesWithEndport []string) could be replaced with func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithEndport, egressPoliciesWithEndport []string) (gocritic)
|
|
Lint (1.22.x, ubuntu-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L115
paramTypeCombine: func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithCIDR []string, egressPoliciesWithCIDR []string) could be replaced with func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithCIDR, egressPoliciesWithCIDR []string) (gocritic)
|
|
Lint (1.22.x, ubuntu-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L165
paramTypeCombine: func(namespaces *corev1.NamespaceList, servicesByNamespace map[string][]*corev1.Service, policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (unsafeServices []string, noSelectorServices []string) could be replaced with func(namespaces *corev1.NamespaceList, servicesByNamespace map[string][]*corev1.Service, policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (unsafeServices, noSelectorServices []string) (gocritic)
|
|
Lint (1.22.x, ubuntu-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L253
ptrToRefParam: consider `serviceLabels' to be of non-pointer type (gocritic)
|
|
Lint (1.22.x, ubuntu-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L201
naked return in func `getExternalTrafficPolicyClusterServices` with 37 lines of code (nakedret)
|
|
Lint (1.22.x, ubuntu-latest)
issues found
|
|
Lint (1.22.x, windows-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L83
paramTypeCombine: func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithEndport []string, egressPoliciesWithEndport []string) could be replaced with func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithEndport, egressPoliciesWithEndport []string) (gocritic)
|
|
Lint (1.22.x, windows-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L115
paramTypeCombine: func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithCIDR []string, egressPoliciesWithCIDR []string) could be replaced with func(policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (ingressPoliciesWithCIDR, egressPoliciesWithCIDR []string) (gocritic)
|
|
Lint (1.22.x, windows-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L165
paramTypeCombine: func(namespaces *corev1.NamespaceList, servicesByNamespace map[string][]*corev1.Service, policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (unsafeServices []string, noSelectorServices []string) could be replaced with func(namespaces *corev1.NamespaceList, servicesByNamespace map[string][]*corev1.Service, policiesByNamespace map[string][]*networkingv1.NetworkPolicy) (unsafeServices, noSelectorServices []string) (gocritic)
|
|
Lint (1.22.x, windows-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L253
ptrToRefParam: consider `serviceLabels' to be of non-pointer type (gocritic)
|
|
Lint (1.22.x, windows-latest):
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go#L201
naked return in func `getExternalTrafficPolicyClusterServices` with 37 lines of code (nakedret)
|
|
Lint (1.22.x, windows-latest)
issues found
|
|
Lint (1.23.x, ubuntu-latest)
Restore cache failed: Dependencies file is not found in /home/runner/work/azure-container-networking/azure-container-networking. Supported file pattern: go.sum
|
|
Lint (1.23.x, windows-latest)
Restore cache failed: Dependencies file is not found in D:\a\azure-container-networking\azure-container-networking. Supported file pattern: go.sum
|
|
Lint (1.22.x, ubuntu-latest)
Restore cache failed: Dependencies file is not found in /home/runner/work/azure-container-networking/azure-container-networking. Supported file pattern: go.sum
|
|
Lint (1.22.x, windows-latest)
Restore cache failed: Dependencies file is not found in D:\a\azure-container-networking\azure-container-networking. Supported file pattern: go.sum
|