feat: update CS image in deployment environments to include new changes #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsorianod
requested review from
bennerv,
geoberle,
janboll,
weinong,
whober0521,
jonathan34c,
tony-schndr,
jfchevrette,
mmazur and
stevekuznetsov
as code owners
janboll
previously approved these changes
Feb 27, 2025
|
Although the tests passed I am going to update this MR with a new SHA |
A non exhaustive list of new changes are: - Fix ARO-HCP Node Pools reconciling when using OCM Commercial endpoints - Limit and validate CS environment attribute length at CS startup time - Validate the Managed Resource Group of a given ARO-HCP cluster being created is unique within an Azure Subscription - Validate that the Managed Resource Group of a given ARO-HCP cluster being created does not have the same name as the Resource Group of that same cluster
miguelsorianod
force-pushed
the
msoriano-update-cs-image-nprepl-reconciling-fix
branch
from
520446a to
9211335
Compare
geoberle
approved these changes
Feb 27, 2025
miguelsorianod
deleted the
msoriano-update-cs-image-nprepl-reconciling-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Updates the CS image, corresponding to tag 2a03722.
A non exhaustive list of new changes are:
endpoints
CS startup time
cluster being created is unique within an Azure Subscription
cluster being created does not have the same name as
the Resource Group of that same cluster
Jira:
Link to demo recording:
Special notes for your reviewer