Improve Availability Zone selection when provisioning AKS and zone-redundant resources #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfchevrette
requested review from
bennerv,
geoberle,
janboll,
jmelis,
jonathan34c,
SudoBrendan,
UlrichSchlueter,
weinong,
whober0521 and
tony-schndr
as code owners
tony-schndr
approved these changes
Feb 10, 2025
| @@ -255,7 +252,7 @@ module istioIngressGatewayIPAddress '../modules/network/publicipaddress.bicep' = | |||
| name: istioIngressGatewayIPAddressName | |||
| ipTags: istioIngressGatewayIPAddressIPTagsArray | |||
| location: location | |||
| zones: zoneRedundancyZones | |||
| zones: locationHasAvailabilityZones ? locationAvailabilityZones : null | |||
There was a problem hiding this comment.
nit: could set this as a variable at the top, right?
There was a problem hiding this comment.
I think it reads better without another variable which may not convey the two possible outcomes
... to account for regions with varied number of AZs and the eventuality that AZ names could be something other than 1,2,3
jfchevrette
force-pushed
the
per-region-az-selection
branch
from
66f57ba to
106e2f5
Compare
geoberle
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
common.bicepfileJira: https://issues.redhat.com/browse/XCMSTRAT-1067
Link to demo recording:
Special notes for your reviewer