Skip to content

Commit

Permalink
Add registry attribute and apply to ACRPull
Browse files Browse the repository at this point in the history
  • Loading branch information
janboll committed Feb 26, 2025
1 parent fa2ccf4 commit 59733dd
Show file tree
Hide file tree
Showing 11 changed files with 24 additions and 7 deletions.
2 changes: 1 addition & 1 deletion acrpull/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ deploy:
kubectl create namespace acrpull --dry-run=client -o json | kubectl apply -f - && \
${HELM_CMD} acrpull \
deploy/helm/acrpull/ \
--set image=${ACRPULL_REPO}@${ACRPULL_DIGEST} \
--set image=${ACRPULL_REGISTRY}/${ACRPULL_REPO}@${ACRPULL_DIGEST} \
--namespace acrpull
.PHONY: deploy

Expand Down
4 changes: 4 additions & 0 deletions acrpull/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ resourceGroups:
configRef: acrPull.image.digest
- name: ACRPULL_REPO
configRef: acrPull.image.repository
- name: ACRPULL_REGISTRY
configRef: acrPull.image.registry
- name: {{ .mgmt.rg }}
subscription: {{ .mgmt.subscription }}
aksCluster: {{ .mgmt.aks.name }}
Expand All @@ -34,3 +36,5 @@ resourceGroups:
configRef: acrPull.image.digest
- name: ACRPULL_REPO
configRef: acrPull.image.repository
- name: ACRPULL_REGISTRY
configRef: acrPull.image.registry
3 changes: 2 additions & 1 deletion config/config.msft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ defaults:
# ACR Pull
acrPull:
image:
repository: mcr.microsoft.com/aks/msi-acrpull
registry: mcr.microsoft.com
repository: aks/msi-acrpull
digest: sha256:51dd1a7c217b554d7925e67008caf747c8bec17b641830160e08b6836a8aa589 #v0.1.12


Expand Down
3 changes: 3 additions & 0 deletions config/config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@
"containerImage": {
"type": "object",
"properties": {
"registry": {
"type": "string"
},
"repository": {
"type": "string"
},
Expand Down
3 changes: 2 additions & 1 deletion config/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ defaults:
# ACR Pull
acrPull:
image:
repository: mcr.microsoft.com/aks/msi-acrpull
registry: mcr.microsoft.com
repository: aks/msi-acrpull
digest: sha256:51dd1a7c217b554d7925e67008caf747c8bec17b641830160e08b6836a8aa589 #v0.1.12

# Hypershift
Expand Down
3 changes: 2 additions & 1 deletion config/public-cloud-cs-pr.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"acrPull": {
"image": {
"digest": "sha256:51dd1a7c217b554d7925e67008caf747c8bec17b641830160e08b6836a8aa589",
"repository": "mcr.microsoft.com/aks/msi-acrpull"
"registry": "mcr.microsoft.com",
"repository": "aks/msi-acrpull"
}
},
"armHelperCertName": "armHelperCert2",
Expand Down
3 changes: 2 additions & 1 deletion config/public-cloud-dev.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"acrPull": {
"image": {
"digest": "sha256:51dd1a7c217b554d7925e67008caf747c8bec17b641830160e08b6836a8aa589",
"repository": "mcr.microsoft.com/aks/msi-acrpull"
"registry": "mcr.microsoft.com",
"repository": "aks/msi-acrpull"
}
},
"armHelperCertName": "armHelperCert2",
Expand Down
3 changes: 2 additions & 1 deletion config/public-cloud-msft-int.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"acrPull": {
"image": {
"digest": "sha256:51dd1a7c217b554d7925e67008caf747c8bec17b641830160e08b6836a8aa589",
"repository": "mcr.microsoft.com/aks/msi-acrpull"
"registry": "mcr.microsoft.com",
"repository": "aks/msi-acrpull"
}
},
"armHelperCertName": "armHelperCert2",
Expand Down
3 changes: 2 additions & 1 deletion config/public-cloud-personal-dev.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"acrPull": {
"image": {
"digest": "sha256:51dd1a7c217b554d7925e67008caf747c8bec17b641830160e08b6836a8aa589",
"repository": "mcr.microsoft.com/aks/msi-acrpull"
"registry": "mcr.microsoft.com",
"repository": "aks/msi-acrpull"
}
},
"armHelperCertName": "armHelperCert2",
Expand Down
2 changes: 2 additions & 0 deletions dev-infrastructure/mgmt-pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -121,5 +121,7 @@ resourceGroups:
configRef: acrPull.image.digest
- name: ACRPULL_REPO
configRef: acrPull.image.repository
- name: ACRPULL_REGISTRY
configRef: acrPull.image.registry
dependsOn:
- mgmt-cluster
2 changes: 2 additions & 0 deletions dev-infrastructure/svc-pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -132,5 +132,7 @@ resourceGroups:
configRef: acrPull.image.digest
- name: ACRPULL_REPO
configRef: acrPull.image.repository
- name: ACRPULL_REGISTRY
configRef: acrPull.image.registry
dependsOn:
- svc

0 comments on commit 59733dd

Please sign in to comment.