Skip to content

Commit

Permalink
Use default block size with zstd compression
Browse files Browse the repository at this point in the history
  • Loading branch information
Samueru-sama authored and TheAssassin committed Aug 8, 2024
1 parent 55fc58b commit 81ee1db
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/appimagetool.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,12 +156,13 @@ int sfs_mksquashfs(char *source, char *destination, int offset) {
args[i++] = "16384";
} else if (strcmp(sqfs_comp, "zstd") == 0) {
/*
* > Build with 1MiB block size
* > Using a bigger block size than mksquashfs's default improves read speed and can produce smaller AppImages as well
* -- https://github.com/probonopd/go-appimage/commit/c4a112e32e8c2c02d1d388c8fa45a9222a529af3
* > Build with default 128K block size
* > It used to be 1M but that actually causes much higher startup times.
* > Some testing might be needed to see if there is some other value that actually improves performance.
* -- https://github.com/AppImage/appimagetool/issues/64
*/
args[i++] = "-b";
args[i++] = "1M";
args[i++] = "128K";
}

// check if ignore file exists and use it if possible
Expand Down

0 comments on commit 81ee1db

Please sign in to comment.