Minor Chores #12
Merged
Minor Chores #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed an unnecessary comment in EphemeralPoolTickBitmap.sol. Added a return statement in PositionUtils.sol and renamed the variable 's' to 'slot0'. Updated package.json to include the --isolate option in the snapshot commands. Also, updated the gas-snapshot with new metrics.
Updated versions of all GitHub actions across multiple workflow files, switching to Node.js 20.x and checkout@v4 along with setup-node@v4. Also enhanced the Rust workflow by changing the way Rust is installed and checks are performed. Also added corresponding GitHub Actions build status badges to the README file.
This commit updates the versions of different dependencies in Cargo.toml and Cargo.lock. Significant updates include the version for "aperture-lens" and other dependencies like "aes", "aho-corasick", "anyhow" and more. In addition, some dependencies are removed in the Cargo.lock file.
This commit includes changes to deactivate certain Clippy lint warnings for complex types and improve the clarity of the code. Specifically, changes were made to pool_lens.rs and position_lens.rs that involved simplification of method parameters and vector constructions. These changes are intended to enhance readability and maintainability of the code.
The formatting check stage using `cargo fmt` has been removed from the Rust workflow in GitHub actions. This change simplifies the workflow configuration and avoids potential formatting-related build failures.
The code has been refactored to create forks after the initialization process rather than before, allowing proper configuration of state variables for each chain. Additional token and pool validations have been introduced for enhanced reliability. This update fixed an issue with initiating forks in BNB, and the 'verifyTicks' and 'verifyPosition' methods now have a 'view' visibility specifier for better encapsulation.
gnarlycow
approved these changes
Apr 3, 2024
|
Feel free to merge it. CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.