Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sakari/feature/clan overview #97

Merged
merged 75 commits into from
Sep 25, 2024
Merged

Sakari/feature/clan overview #97

merged 75 commits into from
Sep 25, 2024

Conversation

Skoivumaki
Copy link
Member

@Skoivumaki Skoivumaki commented Sep 18, 2024

Main feature: Clan Overview page

URL: "altzone.fi/clans/{clan id}"
A page to view clan information which includes: name, small information like wealth and all players in clan listed + their roles.
Example usage: when viewing all clans page and clicking a clan, overview page about said clan is shown.

Features

  • New component: Clan overview desktop/mobile that includes:
  • Viewing all players in clan
  • Basic information of clan
  • Clan name
  • List for browsing clans with search funcitonality
  • Ability to Join or Leave clans in overview and endpoints related to them
  • New custom hooks for handling clan data and hook to retrieve player status/role in clan
  • New query: useGetClanByIdWithPlayersQuery
  • Changed background

Features ready to be used but not implemented yet in backend

  • Most of clan information
  • Clan Logo
  • Preview of clans soulhome
  • Clan Motto

Fixes

  • "Request to leave a Clan" API url was changed in backend.

Note

  • Edit mode in overview or as a separate page (was disabled since button didnt have functionality and might not be needed in overview)

@Skoivumaki
Copy link
Member Author

we have a custom scrollbar, please use it. image

Now using: @include custom-scrollbar;

@Skoivumaki
Copy link
Member Author

Skoivumaki commented Sep 24, 2024

@leolabdev thoughts on unresolved comment thx
image
Noticed that search for clan component is overflowing from parent will fix before code review

leolabdev and others added 8 commits September 25, 2024 14:55
Refactor import statements in authUser.d.ts to use absolute paths instead of relative paths. This change aims to improve code readability and maintainability.
Streamline the `useClientTranslation` call by directly casting the `lng` parameter instead of introducing a redundant variable. This makes the code more concise and easier to read.
Refactor useLeaveClan to remove unnecessary variable assignment by directly passing lng as a string to useClientTranslation. This change simplifies the code and improves readability.
Copy link
Member

@leolabdev leolabdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@leolabdev leolabdev merged commit a676da8 into dev Sep 25, 2024
1 check passed
@leolabdev leolabdev deleted the sakari/feature/clan-overview branch September 25, 2024 13:25
@leolabdev leolabdev added this to the Clans milestone Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants