-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sakari/feature/clan overview #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponent for better readability
@leolabdev thoughts on unresolved comment thx |
…was too far from mainpage (margin top)
Refactor import statements in authUser.d.ts to use absolute paths instead of relative paths. This change aims to improve code readability and maintainability.
…-Org/Altzone-WebPages into sakari/feature/clan-overview
Streamline the `useClientTranslation` call by directly casting the `lng` parameter instead of introducing a redundant variable. This makes the code more concise and easier to read.
Refactor useLeaveClan to remove unnecessary variable assignment by directly passing lng as a string to useClientTranslation. This change simplifies the code and improves readability.
…to sakari/feature/clan-overview
…-Org/Altzone-WebPages into sakari/feature/clan-overview
leolabdev
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main feature: Clan Overview page
URL: "altzone.fi/clans/{clan id}"
A page to view clan information which includes: name, small information like wealth and all players in clan listed + their roles.
Example usage: when viewing all clans page and clicking a clan, overview page about said clan is shown.
Features
Features ready to be used but not implemented yet in backend
Fixes
Note